linux-kernel - Re: [PATCH v2 1/4] dt-bindings: opp: adreno: Update regex of OPP entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <750da319-d25f-454d-b376-ebbc194e0e41@kernel.org>
Date: Thu, 12 Jun 2025 13:29:40 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Akhil P Oommen <quic_akhilpo@...cinc.com>,
 Akhil P Oommen <akhilpo@....qualcomm.com>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Rob Clark <robin.clark@....qualcomm.com>, Sean Paul <sean@...rly.run>,
 Konrad Dybcio <konradybcio@...nel.org>, Dmitry Baryshkov <lumag@...nel.org>,
 Abhinav Kumar <abhinav.kumar@...ux.dev>,
 Jessica Zhang <jessica.zhang@....qualcomm.com>,
 Marijn Suijten <marijn.suijten@...ainline.org>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Viresh Kumar <vireshk@...nel.org>,
 Nishanth Menon <nm@...com>, Stephen Boyd <sboyd@...nel.org>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 freedreno@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-pm@...r.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: opp: adreno: Update regex of OPP
 entry

On 11/06/2025 14:24, Akhil P Oommen wrote:
>>>  
>>>  patternProperties:
>>> -  '^opp-[0-9]+$':
>>> +  '^opp(-?[0-9]+)*$':
>>
>> Not correct regex. You allow "opp", "opp1" and all other unusual
>> variants. Commit does not explain what problem you are solving, so I
>> have no clue what you want here, but for sure opp1 is wrong.
> 
> Just to confirm, would this be fine for the requirement I mentioned above?
> 
> "'^opp(-[0-9]+)*$'"

No, You did not solve half of the problems - still allows "opp" and
commit msg does not explain why "opp" is now correct. Describe the
actual problem and then write the regex solving it in specific way, not
causing other effects.

Best regards,
Krzysztof