linux-kernel - Re: [PATCH] drm/ssd130x: fix ssd132x_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87frg5w56s.fsf@minerva.mail-host-address-is-not-set>
Date: Thu, 12 Jun 2025 13:49:15 +0200
From: Javier Martinez Canillas <javierm@...hat.com>
To: Thomas Zimmermann <tzimmermann@...e.de>, John Keeping
 <jkeeping@...usicbrands.com>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
 <mripard@...nel.org>, David Airlie <airlied@...il.com>, Simona Vetter
 <simona@...ll.ch>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/ssd130x: fix ssd132x_clear_screen() columns

Thomas Zimmermann <tzimmermann@...e.de> writes:

Hello Thomas,

> Hi
>
> Am 11.06.25 um 14:47 schrieb Javier Martinez Canillas:
>> John Keeping <jkeeping@...usicbrands.com> writes:
>>
>> Hello John,
>>
>>> The number of columns relates to the width, not the height.  Use the
>>> correct variable.
>>>
>>> Signed-off-by: John Keeping <jkeeping@...usicbrands.com>
>>> ---
>>>   drivers/gpu/drm/solomon/ssd130x.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c
>>> index dd2006d51c7a2..eec43d1a55951 100644
>>> --- a/drivers/gpu/drm/solomon/ssd130x.c
>>> +++ b/drivers/gpu/drm/solomon/ssd130x.c
>>> @@ -974,7 +974,7 @@ static void ssd130x_clear_screen(struct ssd130x_device *ssd130x, u8 *data_array)
>>>   
>>>   static void ssd132x_clear_screen(struct ssd130x_device *ssd130x, u8 *data_array)
>>>   {
>>> -	unsigned int columns = DIV_ROUND_UP(ssd130x->height, SSD132X_SEGMENT_WIDTH);
>>> +	unsigned int columns = DIV_ROUND_UP(ssd130x->width, SSD132X_SEGMENT_WIDTH);
>>>   	unsigned int height = ssd130x->height;
>>>   
>> Ups, indeed. Thanks for fixing it!
>>
>> Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>
>
> Could you please add a Fixes tag before merging the patch? Thanks!
>

Sure, I'll add the following tag:

Fixes: fdd591e00a9c ("drm/ssd130x: Add support for the SSD132x OLED controller family")

before merging the patch.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat