linux-kernel - Re: [PATCH v2] rust : Update the bios_limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72=8rHB0bU0yUf_tkVG4LzGMUmLVrZHHn6VU584_JJ_obQ@mail.gmail.com>
Date: Thu, 12 Jun 2025 13:55:32 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Abhinav Ananthu <abhinav.ogl@...il.com>
Cc: "Rafael J . Wysocki" <rafael@...nel.org>, Viresh Kumar <viresh.kumar@...aro.org>, 
	Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, linux-pm@...r.kernel.org, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] rust : Update the bios_limit_callback to use the C FFI
 types #1170

On Thu, Jun 12, 2025 at 12:42 PM Abhinav Ananthu <abhinav.ogl@...il.com> wrote:
>
> This change ensures the Rust function signature exactly matches its expected
> C counterpart, avoiding potential issues with type mismatches in the FFI
> boundary.

I think this is more of a cleanup, since the types will be the same
anyway, which is why I suggested using "Suggested-by" and "Link"
instead:

Suggested-by: Miguel Ojeda <ojeda@...nel.org>
Link: https://github.com/Rust-for-Linux/linux/issues/1170

The title is still not correct (misses "cpufreq: ") and it is very
rare to have issue IDs in the title ("#1170").

But there is no need to send a new version just for this -- the
maintainers may want to fix it on apply, so please wait to see what
they say.

Thanks!

Cheers,
Miguel