linux-kernel - Re: [PATCH] arm64: defconfig: Build STMMAC Ethernet driver into the kernel for NFS boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d05f2c03-fa86-4fc6-9b81-1a7b5592c2e8@nvidia.com>
Date: Thu, 12 Jun 2025 13:20:32 +0100
From: Jon Hunter <jonathanh@...dia.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Geert Uytterhoeven <geert@...ux-m68k.org>,
 Prabhakar <prabhakar.csengg@...il.com>
Cc: Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Bjorn Andersson <bjorn.andersson@....qualcomm.com>,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-renesas-soc@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com>,
 Fabrizio Castro <fabrizio.castro.jz@...esas.com>,
 Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
 "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] arm64: defconfig: Build STMMAC Ethernet driver into the
 kernel for NFS boot

Hi Geert,

On 23/05/2025 12:54, Krzysztof Kozlowski wrote:
> On 23/05/2025 13:39, Geert Uytterhoeven wrote:
>> On Tue, 6 May 2025 at 12:47, Prabhakar <prabhakar.csengg@...il.com> wrote:
>>> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
>>>
>>> Enable `CONFIG_STMMAC_ETH` as built-in (`y`) instead of a module (`m`) to
>>> ensure the Ethernet driver is available early in the boot process. This
>>> is necessary for platforms mounting the root filesystem via NFS, as the
>>> driver must be available before the root filesystem is accessed.
>>>
>>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
>>> ---
>>> With this change, the Renesas RZ/V2H EVK board can boot from NFS
>>> which has the DWMAC IP.
>>
>> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
>> i.e. will queue in renesas-devel for v6.17.
> 
> With my Nacked, please.


I was surprised to see this change in -next. We also use NFS for testing 
and we use the dwmac drivers. To date we are explictly building these 
drivers into the initramfs but I noticed that that is now failing 
because this driver is no longer a module by default. This is easy for 
us to fix.

I do agree that if we start to build every networking driver into the 
kernel it is going to bloat. Yes I do see the kernel image growing 
regardless of this, but nonetheless it seems better to just build as a 
module IMO.

Jon

-- 
nvpublic