linux-kernel - Re: [PATCH net] ionic: Prevent driver/fw getting out of sync on devcmd(s)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250612130806.GA414686@horms.kernel.org>
Date: Thu, 12 Jun 2025 14:08:06 +0100
From: Simon Horman <horms@...nel.org>
To: Shannon Nelson <shannon.nelson@....com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, brett.creeley@....com
Subject: Re: [PATCH net] ionic: Prevent driver/fw getting out of sync on
 devcmd(s)

On Mon, Jun 09, 2025 at 02:28:27PM -0700, Shannon Nelson wrote:
> From: Brett Creeley <brett.creeley@....com>
> 
> Some stress/negative firmware testing around devcmd(s) returning
> EAGAIN found that the done bit could get out of sync in the
> firmware when it wasn't cleared in a retry case.
> 
> While here, change the type of the local done variable to a bool
> to match the return type from ionic_dev_cmd_done().
> 
> Fixes: ec8ee714736e ("ionic: stretch heartbeat detection")
> Signed-off-by: Brett Creeley <brett.creeley@....com>
> Signed-off-by: Shannon Nelson <shannon.nelson@....com>

Reviewed-by: Simon Horman <horms@...nel.org>