linux-kernel - Unused trace events in nfs and nfsd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250612215801.2c4c0ff8@batman.local.home>
Date: Thu, 12 Jun 2025 21:58:01 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: LKML <linux-kernel@...r.kernel.org>, linux-nfs@...r.kernel.org
Cc: Chuck Lever <chuck.lever@...cle.com>, Trond Myklebust
 <trond.myklebust@...merspace.com>, NeilBrown <neil@...wn.name>, Jeff Layton
 <jlayton@...nel.org>
Subject: Unused trace events in nfs and nfsd

I have code that will trigger a warning if a trace event is defined but
not used[1]. It gives a list of unused events. Here's what I have in nfs
and nfsd:

warning: tracepoint 'nfs4_renew' is unused.
warning: tracepoint 'nfs4_rename' is unused.
warning: tracepoint 'nfsd_file_unhash_and_queue' is unused.
warning: tracepoint 'nfsd_file_lru_add_disposed' is unused.
warning: tracepoint 'nfsd_file_lru_del_disposed' is unused.
warning: tracepoint 'nfsd_file_gc_recent' is unused.
warning: tracepoint 'nfsd_ctl_maxconn' is unused.

nfs4_renew looks to never have been used.

trace_nfs4_rename() was removed by 33912be816d9 ("nfs: remove
synchronous rename code") but did not remove the event.

trace_nfsd_file_unhash_and_queue() was removed by ac3a2585f01 ("nfsd:
rework refcounting in filecache")

Events nfsd_file_lru_add_disposed and nfsd_file_lru_del_disposed were
added by 4a0e73e635e3 ("NFSD: Leave open files out of the filecache
LRU") but they were never used.

Event nfsd_file_gc_recent was added by 64912122a4f8 ("nfsd: filecache:
introduce NFSD_FILE_RECENT") but never used.

trace_nfsd_ctl_maxconn() was removed by a4b853f183a1 ("sunrpc: remove
all connection limit configuration") but did not remove the event.

-- Steve

[1] https://lore.kernel.org/linux-trace-kernel/20250612235827.011358765@goodmis.org/