linux-kernel - Re: [PATCH] drm/msm: Fix inverted WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DALHS6EU059G.18NCREBNOHJ26@linaro.org>
Date: Fri, 13 Jun 2025 15:57:40 +0100
From: "Alexey Klimov" <alexey.klimov@...aro.org>
To: "Rob Clark" <robin.clark@....qualcomm.com>,
 <dri-devel@...ts.freedesktop.org>
Cc: <freedreno@...ts.freedesktop.org>, <linux-arm-msm@...r.kernel.org>,
 "Konrad Dybcio" <konrad.dybcio@....qualcomm.com>, "Neil Armstrong"
 <neil.armstrong@...aro.org>, "Rob Clark" <robdclark@...il.com>, "Sean Paul"
 <sean@...rly.run>, "Konrad Dybcio" <konradybcio@...nel.org>, "Abhinav
 Kumar" <quic_abhinavk@...cinc.com>, "Dmitry Baryshkov" <lumag@...nel.org>,
 "Marijn Suijten" <marijn.suijten@...ainline.org>, "David Airlie"
 <airlied@...il.com>, "Simona Vetter" <simona@...ll.ch>, "open list"
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/msm: Fix inverted WARN_ON() logic

On Fri Jun 13, 2025 at 3:41 PM BST, Rob Clark wrote:
> We want to WARN_ON() if info is NULL.
>
> Suggested-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> Fixes: 0838fc3e6718 ("drm/msm/adreno: Check for recognized GPU before bind")
> Tested-by: Neil Armstrong <neil.armstrong@...aro.org>
> Signed-off-by: Rob Clark <robin.clark@....qualcomm.com>
> ---
>  drivers/gpu/drm/msm/adreno/adreno_device.c | 2 +-

Apart from tag problem it is usually a good idea to add relevant people in
c/c. Especially when you fix the reported bug.

Best regards,
Alexey