linux-kernel - Re: [PATCH] mfd: Remove node variables that are unused with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250613160600.GA228083@ax162>
Date: Fri, 13 Jun 2025 09:06:00 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Lee Jones <lee@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>, Jiri Slaby <jirislaby@...nel.org>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Andreas Kemnade <andreas@...nade.info>,
	Kevin Hilman <khilman@...libre.com>,
	Roger Quadros <rogerq@...nel.org>, Tony Lindgren <tony@...mide.com>,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH] mfd: Remove node variables that are unused with
 CONFIG_OF=n

On Fri, Jun 13, 2025 at 02:39:05PM +0100, Lee Jones wrote:
> On Wed, 28 May 2025, Nathan Chancellor wrote:
> 
> > Hi Thomas,
> > 
> > On Thu, May 08, 2025 at 04:57:24PM +0100, Nathan Chancellor wrote:
> > > A recent cleanup introduced a few instances of -Wunused-variable in
> > > configurations without CONFIG_OF because of_fwnode_handle() does not
> > > reference its argument in that case:
> > > 
> > >   drivers/mfd/twl4030-irq.c: In function 'twl4030_init_irq':
> > >   drivers/mfd/twl4030-irq.c:679:46: warning: unused variable 'node' [-Wunused-variable]
> > >     679 |         struct                  device_node *node = dev->of_node;
> > >         |                                              ^~~~
> > >   drivers/mfd/max8925-core.c: In function 'max8925_irq_init':
> > >   drivers/mfd/max8925-core.c:659:29: warning: unused variable 'node' [-Wunused-variable]
> > >     659 |         struct device_node *node = chip->dev->of_node;
> > >         |                             ^~~~
> > >   drivers/mfd/88pm860x-core.c: In function 'device_irq_init':
> > >   drivers/mfd/88pm860x-core.c:576:29: warning: unused variable 'node' [-Wunused-variable]
> > >     576 |         struct device_node *node = i2c->dev.of_node;
> > >         |                             ^~~~
> > 
> > These warnings are now present in mainline after the merge of the
> > irq/cleanups branch...
> > 
> > > Use the value of these variables as the argument to of_fwnode_handle()
> > > directly, clearing up the warnings.
> > > 
> > > Fixes: e3d44f11da04 ("mfd: Switch to irq_domain_create_*()")
> > 
> > but this hash has changed, so this should be
> > 
> > Fixes: a36aa0f7226a ("mfd: Switch to irq_domain_create_*()")
> > 
> > but the rest of the change is still applicable. Would you like a new
> > change or can you adjust that when applying?
> 
> Okay, please rebase and resubmit.
> 
> I suspect at least one of these has been fixed by Arnd already.

All of these are addressed by commit fc5f017a71d0 ("mfd: Fix building
without CONFIG_OF") in your tree. Is that going to be merged into 6.16?

Cheers,
Nathan