linux-kernel - Re: [PATCH] hv: add CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <c449d792-fcdc-4b08-a76e-519c0a64525d@app.fastmail.com>
Date: Fri, 13 Jun 2025 18:06:53 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Michael Kelley" <mhklinux@...look.com>,
 "Roman Kisel" <romank@...ux.microsoft.com>, "Arnd Bergmann" <arnd@...nel.org>
Cc: "Dexuan Cui" <decui@...rosoft.com>,
 "Haiyang Zhang" <haiyangz@...rosoft.com>,
 "K. Y. Srinivasan" <kys@...rosoft.com>,
 "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "nunodasneves@...ux.microsoft.com" <nunodasneves@...ux.microsoft.com>,
 "Saurabh Singh Sengar" <ssengar@...ux.microsoft.com>,
 "Wei Liu" <wei.liu@...nel.org>
Subject: Re: [PATCH] hv: add CONFIG_EFI dependency

On Fri, Jun 13, 2025, at 17:50, Michael Kelley wrote:
> From: Michael Kelley <mhklinux@...look.com> Sent: Tuesday, June 10, 
>
> There are other ways to express the HYPERV dependency on EFI that is
> conditional. But if the condition includes HYPERV_VTL_MODE (which
> it needs to), then there's a dependency loop because
> HYPERV_VTL_MODE depends on HYPERV. So that doesn't work
> either.
>
> To solve the immediate problem, we'll just have to do
>
>     select SYSFB if EFI && !HYPERV_VTL_MODE

Right. Technically, you could do

    select HYPERV_VTL_MODE if !EFI

but that makes no sense from a usability point of view.

> Separately, if we want to express the broader dependency of
> HYPERV on EFI (at least for ARM64), then the dependency of
> HYPERV_VTL_MODE on HYPERV will need to go away. Three
> months back I had suggested not creating that dependency [1],
> but the eventual decision was to add it. [2, and follow discussion]
> We would need to revisit that discussion.
>
> Arnd -- if you'd prefer that I submit the patch, let me know.
> I created the original problem and can clean up the mess. :-)

Yes, please do, I trust you will come up with a better patch
description than I would.

      Arnd