linux-kernel - Re: [PATCH] kernel/entry: Remove unneeded header "common.h"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875xgziprs.ffs@tglx>
Date: Fri, 13 Jun 2025 18:12:55 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Khalid Ali <khaliidcaliy@...il.com>, peterz@...radead.org, luto@...nel.org
Cc: linux-kernel@...r.kernel.org, Khalid Ali <khaliidcaliy@...il.com>
Subject: Re: [PATCH] kernel/entry: Remove unneeded header "common.h"

On Wed, Jun 11 2025 at 07:23, Khalid Ali wrote:
> syscall_user_dispatch() is part syscall user dispatch and it has a
> header already, so this patch moves that function to
> include/linux/syscall_user_dispatch.h which fits well. In that case we don't need 
> common.h anymore. All functions related to syscall
> user dispatch are on that header i mentioned, so this one shouldn't be
> special. We need to access the function from that header.

This word salad does not qualify as a change log. Please read

  https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#changelog

including the documentation it links to.

The reason why common.h exists is that syscall_user_dispatch() is a
internal function, which is on purpose not exposed globally. There is no
reason to expose it globally, so it stays where it is.

Thanks,

        tglx