linux-kernel - Re: [PATCH v1] wifi: iwlegacy: convert to use secs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250613161151.GA205720@wp.pl>
Date: Fri, 13 Jun 2025 18:11:51 +0200
From: Stanislaw Gruszka <stf_xl@...pl>
To: Yuesong Li <liyuesong@...o.com>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	opensource.kernel@...o.com
Subject: Re: [PATCH v1] wifi: iwlegacy: convert to use secs_to_jiffies()

On Thu, Jun 12, 2025 at 10:14:44AM +0800, Yuesong Li wrote:
> Since secs_to_jiffies()(commit:b35108a51cf7) has been introduced, we can
> use it to avoid scaling the time to msec.
> 
> Signed-off-by: Yuesong Li <liyuesong@...o.com>
Acked-by: Stanislaw Gruszka <stf_xl@...pl>

> ---
>  drivers/net/wireless/intel/iwlegacy/4965-mac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlegacy/4965-mac.c b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> index 8e58e97a148f..24a39a968db0 100644
> --- a/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> +++ b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> @@ -1382,7 +1382,7 @@ il4965_hdl_stats(struct il_priv *il, struct il_rx_buf *rxb)
>  	 * we get a thermal update even if the uCode doesn't give us one
>  	 */
>  	mod_timer(&il->stats_periodic,
> -		  jiffies + msecs_to_jiffies(recalib_seconds * 1000));
> +		  jiffies + secs_to_jiffies(recalib_seconds));
>  
>  	if (unlikely(!test_bit(S_SCANNING, &il->status)) &&
>  	    (pkt->hdr.cmd == N_STATS)) {
> -- 
> 2.34.1
>