linux-kernel - Re: [PATCH] fs/resctrl: Optimize code in rdt_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6f9a69e-0c91-408c-97fe-d17b9f938756@arm.com>
Date: Fri, 13 Jun 2025 17:57:33 +0100
From: James Morse <james.morse@....com>
To: Shaopeng Tan <tan.shaopeng@...fujitsu.com>, x86@...nel.org,
 linux-kernel@...r.kernel.org
Cc: Reinette Chatre <reinette.chatre@...el.com>,
 Yury Norov <yury.norov@...il.com>, Dave Martin <dave.martin@....com>,
 fenghuay@...dia.com, peternewman@...gle.com, Babu Moger
 <Babu.Moger@....com>, Borislav Petkov <bp@...en8.de>,
 shameerali.kolothum.thodi@...wei.com, bobo.shaobowang@...wei.com,
 D Scott Phillips OS <scott@...amperecomputing.com>,
 carl@...amperecomputing.com, Koba Ko <kobak@...dia.com>,
 Shanker Donthineni <sdonthineni@...dia.com>, Xin Hao
 <xhao@...ux.alibaba.com>, baolin.wang@...ux.alibaba.com,
 lcherian@...vell.com, amitsinght@...vell.com, Ingo Molnar
 <mingo@...hat.com>, David Hildenbrand <david@...hat.com>,
 H Peter Anvin <hpa@...or.com>, Rex Nie <rex.nie@...uarmicro.com>,
 Jamie Iles <quic_jiles@...cinc.com>, dfustini@...libre.com,
 Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] fs/resctrl: Optimize code in rdt_get_tree()

Hello!

On 13/06/2025 08:37, Shaopeng Tan wrote:
> schemata_list_destroy() has to be called if schemata_list_create() fails.
> 
> rdt_get_tree() calls schemata_list_destroy() in two different ways: 
> directly if schemata_list_create() itself fails and 
> on the exit path via the out_schemata_free goto label.
> 
> Remove schemata_list_destroy() call on schemata_list_create() failure.
> Use existing out_schemata_free goto label instead.

Reviewed-by: James Morse <james.morse@....com>


Thanks,

James