linux-kernel - Re: [PATCH v2 net-next] net: ipconfig: replace strncpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250613172203.GO414686@horms.kernel.org>
Date: Fri, 13 Jun 2025 18:22:03 +0100
From: Simon Horman <horms@...nel.org>
To: Pranav Tyagi <pranav.tyagi03@...il.com>
Cc: davem@...emloft.net, dsahern@...nel.org, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, skhan@...uxfoundation.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH v2 net-next] net: ipconfig: replace strncpy with strscpy

On Thu, Jun 12, 2025 at 05:18:59PM +0530, Pranav Tyagi wrote:
> Replace the deprecated strncpy() with strscpy() as the destination
> buffer is NUL-terminated and does not require any
> trailing NUL-padding. Also increase the length to 252
> as NUL-termination is guaranteed.
> 
> Signed-off-by: Pranav Tyagi <pranav.tyagi03@...il.com>

Hi Pranav,

Thanks for the updated patch.

I agree with your analysis above and that this patch is correct.

Reviewed-by: Simon Horman <horms@...nel.org>