linux-kernel - Re: [PATCH 1/4] sched/fair: Use protect_slice() instead of direct comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <G3zYtTToApj7JI1cZHI1011n7a0hv-rWkAdhb2Jn7mAhGdv28MF9X5DyVqdOh7CtpN--YcvURP3fkB0SY1DERKLzcmA27F3cEhGFutJ7JRE=@gianis.ca>
Date: Fri, 13 Jun 2025 17:39:43 +0000
From: dhaval@...nis.ca
To: Vincent Guittot <vincent.guittot@...aro.org>
Cc: mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com, dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de, vschneid@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] sched/fair: Use protect_slice() instead of direct comparison






On Friday, June 13th, 2025 at 7:10 AM, Vincent Guittot <vincent.guittot@...aro.org> wrote:

> 
> 
> Replace the test by the relevant protect_slice() function.
> 
> Signed-off-by: Vincent Guittot vincent.guittot@...aro.org
> 

Reviewed-by: Dhaval Giani (AMD) <dhaval@...nis.ca>

> ---
> kernel/sched/fair.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 83157de5b808..44a09de38ddf 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -1178,7 +1178,7 @@ static inline bool did_preempt_short(struct cfs_rq *cfs_rq, struct sched_entity
> if (!sched_feat(PREEMPT_SHORT))
> return false;
> 
> - if (curr->vlag == curr->deadline)
> 
> + if (protect_slice(curr))
> return false;
> 
> return !entity_eligible(cfs_rq, curr);
> --
> 2.43.0