linux-kernel - Re: [PATCH] lib/crc: re-disable optimized CRC code on user-mode Linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250613184137.GC1284@sol>
Date: Fri, 13 Jun 2025 11:41:37 -0700
From: Eric Biggers <ebiggers@...nel.org>
To: linux-kernel@...r.kernel.org
Cc: linux-crypto@...r.kernel.org, Ard Biesheuvel <ardb@...nel.org>,
	"Jason A . Donenfeld " <Jason@...c4.com>, x86@...nel.org
Subject: Re: [PATCH] lib/crc: re-disable optimized CRC code on user-mode Linux

On Wed, Jun 11, 2025 at 10:45:14PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> The reorganization of lib/crc/ unintentionally enabled the x86-optimized
> CRC64 code on user-mode Linux.  (It's enabled when CONFIG_X86_64, which
> is set by arch/x86/um/Kconfig.  Note that this is a different option
> from the "normal" CONFIG_X86_64 which is defined in arch/x86/Kconfig.)
> Since this is not being taken into account, a build error results:
> 
>     CC      lib/crc/crc64-main.o
>     cc1: error: ./lib/crc/um: No such file or directory [-Werror=missing-include-dirs]
>     lib/crc/crc64-main.c:58:10: fatal error: crc64.h: No such file or directory
>        58 | #include "crc64.h" /* $(SRCARCH)/crc64.h */
>           |          ^~~~~~~~~
>     compilation terminated.
>     cc1: all warnings being treated as errors
> 
> Fix this by re-disabling the optimized CRC code on user-mode Linux.
> 
> Fixes: e2fd1883971d ("lib/crc: prepare for arch-optimized code in subdirs of lib/crc/")
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> ---
>  lib/crc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

FYI: I folded this into the fixed commit, so that it won't be a bisection
hazard.

- Eric