linux-kernel - Re: [PATCH v2] xdp: tracing: Hide some xdp events under CONFIG_BPF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQLkLPv6uvxXz0iWaA06KYXW8_P5fPPX2-WpXOYuXT-B5Q@mail.gmail.com>
Date: Fri, 13 Jun 2025 11:52:44 -0700
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: LKML <linux-kernel@...r.kernel.org>, 
	Linux trace kernel <linux-trace-kernel@...r.kernel.org>, bpf <bpf@...r.kernel.org>, 
	Masami Hiramatsu <mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, 
	Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, 
	"David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Jesper Dangaard Brouer <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>
Subject: Re: [PATCH v2] xdp: tracing: Hide some xdp events under CONFIG_BPF_SYSCALL

On Thu, Jun 12, 2025 at 7:27 PM Steven Rostedt <rostedt@...dmis.org> wrote:
>
> On Thu, 12 Jun 2025 19:16:33 -0700
> Alexei Starovoitov <alexei.starovoitov@...il.com> wrote:
>
> > On Thu, Jun 12, 2025 at 3:20 PM Steven Rostedt <rostedt@...dmis.org> wrote:
> > >
> > > From: Steven Rostedt <rostedt@...dmis.org>
> > >
> > > The events xdp_cpumap_kthread, xdp_cpumap_enqueue and xdp_devmap_xmit are
> > > only called when CONFIG_BPF_SYSCALL is defined.  As each event can take up
> > > to 5K regardless if they are used or not, it's best not to define them
> > > when they are not used. Add #ifdef around these events when they are not
> > > used.
> > >
> > > Acked-by: Jesper Dangaard Brouer <hawk@...nel.org>
> > > Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> > > ---
> > > Changes since v1: https://lore.kernel.org/20250612101612.3d4509cc@batman.local.home
> > >
> > > - Rebased on top of bpf-next
> >
> > We can certainly take it, but you mentioned you're working
> > on some patches that will warn when tracepoint is not used.
> > So do you need this to land sooner than the next merge window ?
>
> No. I plan on sending that code near the end of the next merge window
> to let these patches get in before they start to add warnings.
>
> I'm also going to wait till near the end of this cycle before I add
> that code to linux-next to keep the warnings happening there too soon.
>
> So, please take it. That way there's less likelihood of another
> conflict.

It was applied to bpf-next/net yesterday.
pw-bot didn't notice.