linux-kernel - Re: [PATCH v7 1/5] cdx: add the headers to include/linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250613195924.GB171759@yaz-khff2.amd.com>
Date: Fri, 13 Jun 2025 15:59:24 -0400
From: Yazen Ghannam <yazen.ghannam@....com>
To: Shubhrajyoti Datta <shubhrajyoti.datta@....com>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linux-edac@...r.kernel.org, git@....com,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	Borislav Petkov <bp@...en8.de>, Tony Luck <tony.luck@...el.com>,
	James Morse <james.morse@....com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Robert Richter <rric@...nel.org>, Nipun Gupta <nipun.gupta@....com>,
	Nikhil Agarwal <nikhil.agarwal@....com>
Subject: Re: [PATCH v7 1/5] cdx: add the headers to include/linux

On Thu, May 29, 2025 at 12:30:13PM +0530, Shubhrajyoti Datta wrote:
> Add a the bitfield.h and mcdi.h headers.

Extra "a"?

> This is in preparation for VersalNET EDAC
> driver that relies on it.
> 
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@....com>
> ---
> 
> Changes in v7:
> - add a minimal header instead moving them
> 
> Changes in v6:
>  - Patch added
> 
>  include/linux/cdx/bitfield.h |  78 ++++++++++++++
>  include/linux/cdx/mcdi.h     | 192 +++++++++++++++++++++++++++++++++++

These only get used by VersalNET EDAC driver at the end.

So the headers can go in drivers/edac.

Also, maybe these can all be a single header file? It seems like each
one is just included in the next one.

	$ git grep "cdx/bitfield"
	include/linux/cdx/mcdi.h:#include "linux/cdx/bitfield.h"
	$ git grep "cdx/mcdi"
	include/linux/cdx/edac_cdx_pcol.h:#include  <linux/cdx/mcdi.h>
	$ git grep "cdx/edac_cdx_pcol"
	drivers/edac/versalnet_edac.c:#include <linux/cdx/edac_cdx_pcol.h>

If these are truly independent header files, then the "c" file should
include them all. You should not depend on a header file including other
header files, if possible.

>From "Documentation/process/submit-checklist.rst":
   1) If you use a facility then #include the file that defines/declares
      that facility.  Don't depend on other header files pulling in ones
      that you use.

Thanks,
Yazen