linux-kernel - RE: [PATCH v4 1/5] scsi: fnic: Set appropriate logging level for log message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SJ0PR11MB58960849B96B5BB6875F928AC377A@SJ0PR11MB5896.namprd11.prod.outlook.com>
Date: Fri, 13 Jun 2025 21:45:13 +0000
From: "Karan Tilak Kumar (kartilak)" <kartilak@...co.com>
To: John Meneghini <jmeneghi@...hat.com>, "Sesidhar Baddela (sebaddel)"
	<sebaddel@...co.com>
CC: "Arulprabhu Ponnusamy (arulponn)" <arulponn@...co.com>, "Dhanraj Jhawar
 (djhawar)" <djhawar@...co.com>, "Gian Carlo Boffa (gcboffa)"
	<gcboffa@...co.com>, "Masa Kai (mkai2)" <mkai2@...co.com>, "Satish Kharat
 (satishkh)" <satishkh@...co.com>, "Arun Easi (aeasi)" <aeasi@...co.com>,
	"jejb@...ux.ibm.com" <jejb@...ux.ibm.com>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>, "linux-scsi@...r.kernel.org"
	<linux-scsi@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "revers@...hat.com" <revers@...hat.com>,
	"dan.carpenter@...aro.org" <dan.carpenter@...aro.org>
Subject: RE: [PATCH v4 1/5] scsi: fnic: Set appropriate logging level for log
 message

On Friday, June 13, 2025 1:35 PM, John Meneghini <jmeneghi@...hat.com> wrote:
>
> Please move this patch to the end of the series.
>
> The most important change here is:
>
>   [PATCH v4 2/5] scsi: fnic: Fix crash in fnic_wq_cmpl_handler when FDMI times out
>
>   This is the major fix and and it should come first. All of these other DEBUG PRINTFs are less important.
>
>   Thanks,
>
>   /John
>
>   On 6/12/25 6:18 PM, Karan Tilak Kumar wrote:
>   > Replace KERN_INFO with KERN_DEBUG for a log message.
>   >
>   > Reviewed-by: Sesidhar Baddela <sebaddel@...co.com>
>   > Reviewed-by: Arulprabhu Ponnusamy <arulponn@...co.com>
>   > Reviewed-by: Gian Carlo Boffa <gcboffa@...co.com>
>   > Reviewed-by: Arun Easi <aeasi@...co.com>
>   > Signed-off-by: Karan Tilak Kumar <kartilak@...co.com>
>   > ---
>   >   drivers/scsi/fnic/fnic_scsi.c | 2 +-
>   >   1 file changed, 1 insertion(+), 1 deletion(-)
>   >
>   > diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c
>   > index 7133b254cbe4..75b29a018d1f 100644
>   > --- a/drivers/scsi/fnic/fnic_scsi.c
>   > +++ b/drivers/scsi/fnic/fnic_scsi.c
>   > @@ -1046,7 +1046,7 @@ static void fnic_fcpio_icmnd_cmpl_handler(struct fnic *fnic, unsigned int cq_ind
>   >                   if (icmnd_cmpl->scsi_status == SAM_STAT_TASK_SET_FULL)
>   >                           atomic64_inc(&fnic_stats->misc_stats.queue_fulls);
>   >
>   > -         FNIC_SCSI_DBG(KERN_INFO, fnic->host, fnic->fnic_num,
>   > +         FNIC_SCSI_DBG(KERN_DEBUG, fnic->host, fnic->fnic_num,
>   >                                   "xfer_len: %llu", xfer_len);
>   >                   break;
>   >
>
>

Thanks for your comments, John.
Sure. I can move this to the end the series.

Regards,
Karan