linux-kernel - Re: [PATCH] net: ipv4: ipconfig: Support RFC 4361/3315 DHCP client ID in hex format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <25d73457-cfb7-4e65-bb19-a3a826790f32@cern.ch>
Date: Sat, 14 Jun 2025 00:37:07 +0200
From: Petr Zejdl <petr.zejdl@...n.ch>
To: Jakub Kicinski <kuba@...nel.org>
Cc: petr.zejdl@...n.ch, "David S. Miller" <davem@...emloft.net>,
 David Ahern <dsahern@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ipv4: ipconfig: Support RFC 4361/3315 DHCP client ID
 in hex format

I'm sorry, now in the correct format.

On 13.06.2025 4:17, Jakub Kicinski wrote:
> On Tue, 10 Jun 2025 16:35:03 +0200 Petr Zejdl wrote:
>> -		len = strlen(dhcp_client_identifier + 1);
> maybe keep using len here? Assign dhcp_client_identifier_len to it?
> I don't think switching to dhcp_client_identifier_len improves the
> readability and it inflates the diff.

Indeed.

>> +/*
>> + *  Parses DHCP Client ID in the hex form "XX:XX ... :XX" (like MAC address).
>> + *  Returns the length (min 2, max 253) or -EINVAL on parsing error.
>> + */
>> +static int __init parse_client_id(const char *s, u8 *buf)
>> ...
> Feels like this helper should live in lib/net_utils.c or lib/hexdump.c
> as a generic thing?

Sounds good, will come with a new version.

I should also update 'Documentation/admin-guide/nfs/nfsroot.rst' with
the new Client ID format.

Thank you for the review.

Best regards,
Petr