linux-kernel - Re: [PATCH v1 06/12] iommufd/selftest: Implement mock_get_viommu_size and mock_viommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250613232318.GP1174925@nvidia.com>
Date: Fri, 13 Jun 2025 20:23:18 -0300
From: Jason Gunthorpe <jgg@...dia.com>
To: Nicolin Chen <nicolinc@...dia.com>
Cc: kevin.tian@...el.com, will@...nel.org, robin.murphy@....com,
	joro@...tes.org, ddutile@...hat.com, yi.l.liu@...el.com,
	peterz@...radead.org, jsnitsel@...hat.com, praan@...gle.com,
	linux-arm-kernel@...ts.infradead.org, iommu@...ts.linux.dev,
	linux-kernel@...r.kernel.org, patches@...ts.linux.dev,
	baolu.lu@...ux.intel.com
Subject: Re: [PATCH v1 06/12] iommufd/selftest: Implement
 mock_get_viommu_size and mock_viommu_init

On Fri, Jun 13, 2025 at 01:19:33PM -0700, Nicolin Chen wrote:
> > The patches will read better if you add the call logic for init along
> > side alloc based on init or alloc ops being non-NULL in the prior
> > patch and then have these driver patches replace alloc with init.
> > 
> > Duplicating alloc into init and leaving both makes the patch harder to
> > check.
> 
> I see. That will add an additional patch tentatively supporting
> both ops.

An additional patch is not needed, just add calls to the ops in the
same patch where you add the ops.

Then the patch that removes the old ops removes the extra logic
deciding which set to call. This is the preferred way to do driver
conversions.

Jason