linux-kernel - Re: [patch V2 09/26] timekeeping: Make __timekeeping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANDhNCq8SGR0oD=OZGVVn0z329P20fUt+fxFRGJOv4J_fyJSLA@mail.gmail.com>
Date: Thu, 12 Jun 2025 17:23:13 -0700
From: John Stultz <jstultz@...gle.com>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: LKML <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org, 
	Richard Cochran <richardcochran@...il.com>, Christopher Hall <christopher.s.hall@...el.com>, 
	Frederic Weisbecker <frederic@...nel.org>, Anna-Maria Behnsen <anna-maria@...utronix.de>, 
	Miroslav Lichvar <mlichvar@...hat.com>, Werner Abt <werner.abt@...nberg-usa.com>, 
	David Woodhouse <dwmw2@...radead.org>, Stephen Boyd <sboyd@...nel.org>, 
	Thomas Weißschuh <thomas.weissschuh@...utronix.de>, 
	Kurt Kanzenbach <kurt@...utronix.de>, Nam Cao <namcao@...utronix.de>, 
	Antoine Tenart <atenart@...nel.org>
Subject: Re: [patch V2 09/26] timekeeping: Make __timekeeping_advance() reusable

On Mon, May 19, 2025 at 1:33 AM Thomas Gleixner <tglx@...utronix.de> wrote:
>
> From: Anna-Maria Behnsen <anna-maria@...utronix.de>
>
> In __timekeeping_advance() the pointer to struct tk_data is hardcoded by the
> use of &tk_core. As long as there is only a single timekeeper (tk_core),
> this is not a problem. But when __timekeeping_advance() will be reused for
> per auxiliary timekeepers, __timekeeping_advance() needs to be generalized.
>
> Add a pointer to struct tk_data as function argument of
> __timekeeping_advance() and adapt all call sites.
>
> Signed-off-by: Anna-Maria Behnsen <anna-maria@...utronix.de>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>

Acked-by: John Stultz <jstultz@...gle.com>

thanks
-john