linux-kernel - Re: [PATCH net-next] net: ti: icssg-prueth: Read firmware-names from device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5cb496cc-7b0e-471b-8698-10d26f973cc5@ti.com>
Date: Fri, 13 Jun 2025 09:57:11 +0530
From: MD Danish Anwar <danishanwar@...com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Meghana Malladi <m-malladi@...com>, Paolo Abeni <pabeni@...hat.com>,
        Eric
 Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew+netdev@...n.ch>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <srk@...com>, Vignesh Raghavendra <vigneshr@...com>,
        Roger Quadros
	<rogerq@...nel.org>
Subject: Re: [PATCH net-next] net: ti: icssg-prueth: Read firmware-names from
 device tree



On 12/06/25 8:07 pm, Jakub Kicinski wrote:
> On Thu, 12 Jun 2025 10:49:17 +0530 MD Danish Anwar wrote:
>>> You seem to be deleting the old constants. Is there no need to keep
>>> backward compatibility with DT blobs which don't have the firmware-name
>>> properties ?  
>>
>> ICSSG-PRUETH driver is only supported by AM65x and AM64x and both the
>> DTs have the firmware name property. So I don't think there is any need
>> to maintain the older hard coded values.
>>
>> AM65x -
>> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso#n28:~:text=pru2_1%3E%2C%20%3C%26rtu2_1%3E%2C%20%3C%26tx_pru2_1%3E%3B-,firmware%2Dname,-%3D%20%22ti%2Dpruss/am65x
>>
>> AM64x -
>> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/arch/arm64/boot/dts/ti/k3-am642-evm.dts#:~:text=tx_pru1_1%3E%3B-,firmware%2Dname,-%3D%20%22ti%2Dpruss
>>
>> Let me know if this is okay.
> 
> IDK much about embedded but what you say sounds convincing to me :)
> Just also add that paragraph to the commit msg? (without the links)

Sure. Will send out v2 soon with these changes to commit msg.

-- 
Thanks and Regards,
Danish