linux-kernel - Re: [PATCH v4 1/1] ARM: dts: aspeed: Add device tree for Nvidia's GB200 UT3.0b platform BMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <6a51eda96a7ffbb228ec08877a4f6649413c9bef.camel@codeconstruct.com.au>
Date: Fri, 13 Jun 2025 15:07:29 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Donald Shannon <donalds@...dia.com>, "robh@...nel.org"
 <robh@...nel.org>,  "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>
Cc: "joel@....id.au" <joel@....id.au>, "devicetree@...r.kernel.org"
	 <devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	 <linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	 <linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
	 <linux-kernel@...r.kernel.org>, Ed Tanous <etanous@...dia.com>
Subject: Re: [PATCH v4 1/1] ARM: dts: aspeed: Add device tree for Nvidia's
 GB200 UT3.0b platform BMC

On Thu, 2025-06-12 at 16:59 +0000, Donald Shannon wrote:
> Hi Andrew and Krzysztof,
> 
> The difference in this device tree is adding more GPIO expanders and
> changing the networking.

Can you please include a description of these differences in the commit
message?

> 
> Would it be best practice to create a new device binding (in this
> case nvidia,gb200-ut30b), even if it is just a slight modification on
> gb200nvl-bmc? Or can I reuse the gb200nvl-bmc compatible string and
> avoid the yaml binding change all together since it would share the
> same drivers?

You can include the aspeed-bmc-nvidia-gb200nvl-bmc.dts file and
override the nodes where the differences lie if that helps. There are
existing examples of this strategy, for instance:

   $ git grep '^#include .*\.dts"$' arch/arm/boot/dts/aspeed/
   arch/arm/boot/dts/aspeed/aspeed-ast2600-evb-a1.dts:#include "aspeed-ast2600-evb.dts"
   arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge-4u.dts:#include "aspeed-bmc-ibm-blueridge.dts"
   arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier-1s4u.dts:#include "aspeed-bmc-ibm-rainier-4u.dts"
   arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier-4u.dts:#include "aspeed-bmc-ibm-rainier.dts"

Whether or not the differences warrant a separate compatible - I'm not
sure.

Andrew