lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <7794a9e3b2efbac79b330bba5af7b6e410ca1b3f.camel@codeconstruct.com.au>
Date: Fri, 13 Jun 2025 10:12:54 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Fred Chen <fredchen.openbmc@...il.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski
	 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Joel Stanley
	 <joel@....id.au>, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/2] ARM: dts: aspeed: santabarbara: Add Meta
 Santabarbara BMC

Hi Fred,

On Fri, 2025-06-06 at 18:27 +0800, Fred Chen wrote:
> Add linux device tree entry related to the Meta(Facebook)
> 

We're writing prose, not C function invocations. Please add a space
after 'Meta':

   Meta (Facebook)


>  computer-node
> system use an AT2600 BMC.
> This node is named "Santabarbara".

Can you add some more context for the platform design? It would be
helpful for reviewing the devicetree content below.

> 
> Signed-off-by: Fred Chen <fredchen.openbmc@...il.com>
> ---
>  arch/arm/boot/dts/aspeed/Makefile             |   1 +
>  .../aspeed-bmc-facebook-santabarbara.dts      | 978 ++++++++++++++++++
>  2 files changed, 979 insertions(+)
>  create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-santabarbara.dts
> 
> diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed/Makefile
> index 2e5f4833a073..6a8fb3addf0f 100644
> --- a/arch/arm/boot/dts/aspeed/Makefile
> +++ b/arch/arm/boot/dts/aspeed/Makefile
> @@ -27,6 +27,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
>         aspeed-bmc-facebook-harma.dtb \
>         aspeed-bmc-facebook-minerva.dtb \
>         aspeed-bmc-facebook-minipack.dtb \
> +       aspeed-bmc-facebook-santabarbara.dtb \
>         aspeed-bmc-facebook-tiogapass.dtb \
>         aspeed-bmc-facebook-wedge40.dtb \
>         aspeed-bmc-facebook-wedge100.dtb \
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-santabarbara.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-santabarbara.dts
> new file mode 100644
> index 000000000000..139b986bbfbf
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-santabarbara.dts
> @@ -0,0 +1,978 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +// Copyright 2025 Facebook Inc.
> +
> +/dts-v1/;
> +#include "aspeed-g6.dtsi"
> +#include <dt-bindings/gpio/aspeed-gpio.h>
> +#include <dt-bindings/i2c/i2c.h>
> +
> +/ {
> +       model = "Facebook Santabarbara BMC";
> +       compatible = "facebook,santabarbara-bmc", "aspeed,ast2600";

Throughout the devicetree, can you make sure the nodes adhere to the
ordering requirements defined in the documentation?

https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-nodes

> +
> +       aliases {
> +               serial0 = &uart1;
> +               serial2 = &uart3;
> +               serial3 = &uart4;
> +               serial4 = &uart5;
> +               i2c16 = &i2c4mux0ch0;
> +               i2c17 = &i2c4mux0ch1;
> +               i2c18 = &i2c4mux0ch2;
> +               i2c19 = &i2c4mux0ch3;
> +               i2c20 = &i2c4mux0ch4;
> +               i2c21 = &i2c4mux0ch5;
> +               i2c22 = &i2c4mux0ch6;
> +               i2c23 = &i2c4mux0ch7;
> +               i2c24 = &i2c5mux0ch0;
> +               i2c25 = &i2c5mux0ch1;
> +               i2c26 = &i2c5mux0ch2;
> +               i2c27 = &i2c5mux0ch3;
> +               i2c28 = &i2c5mux1ch0;
> +               i2c29 = &i2c5mux1ch1;
> +               i2c30 = &i2c5mux1ch2;
> +               i2c31 = &i2c5mux1ch3;
> +               i2c32 = &i2c12mux0ch0;
> +               i2c33 = &i2c12mux0ch1;
> +               i2c34 = &i2c12mux0ch2;
> +               i2c35 = &i2c12mux0ch3;
> +               i2c36 = &i2c12mux0ch4;
> +               i2c37 = &i2c12mux0ch5;
> +               i2c38 = &i2c12mux0ch6;
> +               i2c39 = &i2c12mux0ch7;
> +       };
> +
> +       chosen {
> +               stdout-path = "serial4:57600n8";
> +       };
> +
> +       memory@...00000 {
> +               device_type = "memory";
> +               reg = <0x80000000 0x80000000>;
> +       };
> +
> +       iio-hwmon {
> +               compatible = "iio-hwmon";
> +               io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>,
> +                             <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,
> +                             <&adc1 2>;
> +       };
> +
> +       leds {
> +               compatible = "gpio-leds";
> +
> +               led-0 {
> +                       label = "bmc_heartbeat_amber";
> +                       gpios = <&gpio0 ASPEED_GPIO(P, 7) GPIO_ACTIVE_LOW>;
> +                       linux,default-trigger = "heartbeat";
> +               };
> +
> +               led-1 {
> +                       label = "fp_id_amber";
> +                       default-state = "off";
> +                       gpios = <&gpio0 ASPEED_GPIO(B, 5) GPIO_ACTIVE_HIGH>;
> +               };
> +
> +               led-2 {
> +                       label = "power_blue";
> +                       default-state = "off";
> +                       gpios = <&gpio0 ASPEED_GPIO(P, 4) GPIO_ACTIVE_HIGH>;
> +               };
> +       };
> +
> +       spi_gpio: spi {
> +               status = "okay";
> +               compatible = "spi-gpio";
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +
> +               sck-gpios = <&gpio0 ASPEED_GPIO(Z, 3) GPIO_ACTIVE_HIGH>;
> +               mosi-gpios = <&gpio0 ASPEED_GPIO(Z, 4) GPIO_ACTIVE_HIGH>;
> +               miso-gpios = <&gpio0 ASPEED_GPIO(Z, 5) GPIO_ACTIVE_HIGH>;
> +               num-chipselects = <1>;
> +               cs-gpios = <&gpio0 ASPEED_GPIO(Z, 0) GPIO_ACTIVE_LOW>;
> +
> +               tpm@0 {
> +                       compatible = "infineon,slb9670", "tcg,tpm_tis-spi";
> +                       spi-max-frequency = <33000000>;
> +                       reg = <0>;
> +               };
> +       };
> +
> +       p3v3_bmc_aux: regulator-p3v3-bmc-aux {
> +               compatible = "regulator-fixed";
> +               regulator-name = "p3v3_bmc_aux";
> +               regulator-min-microvolt = <3300000>;
> +               regulator-max-microvolt = <3300000>;
> +               regulator-always-on;
> +       };
> +};
> +
> +// HOST BIOS Debug
> +&uart1 {
> +       status = "okay";
> +};
> +
> +&uart3 {
> +       status = "okay";
> +};
> +
> +&uart4 {
> +       status = "okay";
> +};
> +
> +// BMC Debug Console
> +&uart5 {
> +       status = "okay";
> +};
> +
> +&uart_routing {
> +       status = "okay";
> +};
> +
> +&wdt1 {
> +       status = "okay";
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_wdtrst1_default>;
> +       aspeed,reset-type = "soc";
> +       aspeed,external-signal;
> +       aspeed,ext-push-pull;
> +       aspeed,ext-active-high;
> +       aspeed,ext-pulse-duration = <256>;
> +};
> +
> +&mac2 {
> +       status = "okay";
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_rmii3_default>;
> +       use-ncsi;
> +};
> +
> +&fmc {
> +       status = "okay";
> +
> +       flash@0 {
> +               status = "okay";
> +               m25p,fast-read;
> +               label = "bmc";
> +               spi-max-frequency = <50000000>;
> +#include "openbmc-flash-layout-128.dtsi"
> +       };
> +
> +       flash@1 {
> +               status = "okay";
> +               m25p,fast-read;
> +               label = "alt-bmc";
> +               spi-max-frequency = <50000000>;
> +       };
> +};
> +
> +// BIOS Flash
> +&spi2 {
> +       status = "okay";
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_spi2_default>;
> +
> +       flash@0 {
> +               status = "okay";
> +               m25p,fast-read;
> +               label = "pnor";
> +               spi-max-frequency = <12000000>;
> +               spi-tx-bus-width = <2>;
> +               spi-rx-bus-width = <2>;
> +       };
> +};
> +
> +&kcs2 {
> +       status = "okay";
> +       aspeed,lpc-io-reg = <0xca8>;
> +};
> +
> +&kcs3 {
> +       status = "okay";
> +       aspeed,lpc-io-reg = <0xca2>;
> +};
> +
> +&i2c0 {
> +       status = "okay";
> +
> +       // MB FRU
> +       eeprom@53 {
> +               compatible = "atmel,24c128";
> +               reg = <0x53>;
> +       };
> +
> +       rtc@68 {
> +               compatible = "dallas,ds1339";
> +               reg = <0x68>;
> +       };
> +};
> +
> +&i2c1 {
> +       status = "okay";
> +
> +       fan-controller@21{
> +               compatible = "maxim,max31790";
> +               reg = <0x21>;
> +       };
> +
> +       gpio@20 {
> +               compatible = "nxp,pca9555";
> +               reg = <0x20>;
> +               gpio-controller;
> +               #gpio-cells = <2>;
> +               interrupt-parent = <&sgpiom0>;
> +               interrupts = <112 IRQ_TYPE_LEVEL_LOW>;
> +               gpio-line-names =
> +                       "FM_NIC_PPS_IN_OE_N","FM_NIC_PPS_OUT_OE_N",
> +                       "FM_CPU0_TRIGGERTSC_OE_N","FM_NIC_PPS_IN_MUX_OE_N",
> +                       "FM_CPU0_CORETYPE0","FM_CPU0_CORETYPE1",
> +                       "FM_CPU0_CORETYPE2","FM_NIC_PPS_OUT_MUX_OE",
> +                       "CLKMUX_INPUT_LOSS_U45_R_N","FM_CPU0_SP7R1",
> +                       "FM_CPU0_SP7R2","FM_CPU0_SP7R3",
> +                       "FM_CPU0_SP7R4","",
> +                       "FM_NIC_PPS_IN_S0_R","FM_NIC_PPS_IN_S1_R";
> +       };
> +
> +       gpio@22 {
> +               compatible = "nxp,pca9555";
> +               reg = <0x22>;
> +               gpio-controller;
> +               #gpio-cells = <2>;
> +               interrupt-parent = <&sgpiom0>;
> +               interrupts = <116 IRQ_TYPE_LEVEL_LOW>;
> +               gpio-line-names =
> +                       "FM_CBL_PRSNT_0A_N","FM_CBL_PRSNT_0B_N",
> +                       "FM_CBL_PRSNT_1A_N","FM_CBL_PRSNT_1B_N",
> +                       "FM_MODULE_PWRGD_0A","FM_MODULE_PWRGD_0B",
> +                       "CLKMUX_INPUT_LOSS_U88_R_N","FM_MODULE_PWRGD_1B",
> +                       "","",
> +                       "CLKMUX_INPUT_LOSS_U83_R_N","CLKMUX_INPUT_LOSS_U84_R_N",
> +                       "FM_P3V3_E1S_0_FAULT_R_N","FM_P3V3_E1S_1_FAULT_R_N",
> +                       "E1S_0_P12V_ADC_R_ALERT","E1S_1_P12V_ADC_R_ALERT";
> +       };
> +
> +       gpio@24 {
> +               compatible = "nxp,pca9555";
> +               reg = <0x24>;
> +               gpio-controller;
> +               #gpio-cells = <2>;
> +               interrupt-parent = <&sgpiom0>;
> +               interrupts = <114 IRQ_TYPE_LEVEL_LOW>;
> +               gpio-line-names =
> +                       "FM_CBL_PRSNT_2A_N","FM_CBL_PRSNT_2B_N",
> +                       "FM_CBL_PRSNT_3A_N","FM_CBL_PRSNT_3B_N",
> +                       "FM_CBL_PRSNT_4A_N","FM_CBL_PRSNT_4B_N",
> +                       "FM_P3V3_NIC_400G_FAULT_R_N","FM_MODULE_PWRGD_2B",
> +                       "OCP_SFF_P12V_ADC_R_ALERT","FM_MODULE_PWRGD_3B",
> +                       "FM_THERMAL_ALERT_R_N","FM_MODULE_PWRGD_4B",
> +                       "FM_CBL_PRSNT_OSFP_A_N","FM_CBL_PRSNT_OSFP_B_N",
> +                       "FM_JTAG_MCIO_MUX_S0","FM_JTAG_MCIO_MUX_S1";
> +       };
> +
> +       gpio@26 {
> +               compatible = "nxp,pca9555";
> +               reg = <0x26>;
> +               gpio-controller;
> +               #gpio-cells = <2>;
> +               interrupt-parent = <&sgpiom0>;
> +               interrupts = <118 IRQ_TYPE_LEVEL_LOW>;
> +               gpio-line-names =
> +                       "FAN_0_PRSNT_R1_N","FAN_1_PRSNT_R1_N",
> +                       "FAN_2_PRSNT_R1_N","FAN_3_PRSNT_R1_N",
> +                       "P12V_FAN_0_ADC_ALERT","P12V_FAN_1_ADC_ALERT",
> +                       "P12V_FAN_2_ADC_ALERT","P12V_FAN_3_ADC_ALERT",
> +                       "P12V_FAN0_PWRGD_R","P12V_FAN1_PWRGD_R",
> +                       "P12V_FAN2_PWRGD_R","P12V_FAN3_PWRGD_R",
> +                       "","","","";
> +       };
> +};
> +
> +&i2c4 {
> +       status = "okay";
> +
> +       i2c-mux@70 {
> +               compatible = "nxp,pca9548";
> +               reg = <0x70>;
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               i2c-mux-idle-disconnect;
> +
> +               i2c4mux0ch0: i2c@0 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <0>;
> +
> +                       // HPM Board ID EEPROM
> +                       eeprom@51 {
> +                               compatible = "atmel,24c128";
> +                               reg = <0x51>;
> +                       };
> +
> +                       // SCM Board ID EEPROM
> +                       eeprom@53 {
> +                               compatible = "atmel,24c128";
> +                               reg = <0x53>;
> +                       };
> +               };
> +               i2c4mux0ch1: i2c@1 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <1>;
> +               };
> +               i2c4mux0ch2: i2c@2 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <2>;
> +               };
> +               i2c4mux0ch3: i2c@3 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <3>;
> +
> +                       power-monitor@40 {
> +                               compatible = "ti,ina230";
> +                               reg = <0x40>;
> +                               shunt-resistor = <2000>;
> +                       };
> +
> +                       power-monitor@42 {
> +                               compatible = "ti,ina230";
> +                               reg = <0x42>;
> +                               shunt-resistor = <2000>;
> +                       };
> +
> +                       power-monitor@44 {
> +                               compatible = "ti,ina230";
> +                               reg = <0x44>;
> +                               shunt-resistor = <2000>;
> +                       };
> +
> +                       power-monitor@46 {
> +                               compatible = "ti,ina230";
> +                               reg = <0x46>;
> +                               shunt-resistor = <2000>;
> +                       };
> +
> +                       temperature-sensor@4c {
> +                               compatible = "ti,tmp75";
> +                               reg = <0x4c>;
> +                       };
> +
> +                       temperature-sensor@4e {
> +                               compatible = "ti,tmp75";
> +                               reg = <0x4e>;
> +                       };
> +
> +                       voltage-sensor@48 {
> +                               compatible = "ti,ads7830";
> +                               reg = <0x48>;
> +                               vref-supply = <&p3v3_bmc_aux>;
> +                       };
> +
> +                       voltage-sensor@4a {
> +                               compatible = "ti,ads7830";
> +                               reg = <0x4a>;
> +                               vref-supply = <&p3v3_bmc_aux>;
> +                       };
> +               };
> +               i2c4mux0ch4: i2c@4 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <4>;
> +               };
> +               i2c4mux0ch5: i2c@5 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <5>;
> +               };
> +               i2c4mux0ch6: i2c@6 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <6>;
> +
> +                       power-monitor@40 {
> +                               compatible = "ti,ina230";
> +                               reg = <0x40>;
> +                               shunt-resistor = <2000>;
> +                       };
> +
> +                       power-monitor@42 {
> +                               compatible = "ti,ina230";
> +                               reg = <0x42>;
> +                               shunt-resistor = <2000>;
> +                       };
> +
> +                       power-monitor@44 {
> +                               compatible = "ti,ina230";
> +                               reg = <0x44>;
> +                               shunt-resistor = <2000>;
> +                       };
> +
> +                       power-monitor@46 {
> +                               compatible = "ti,ina230";
> +                               reg = <0x46>;
> +                               shunt-resistor = <2000>;
> +                       };
> +
> +                       voltage-sensor@48 {
> +                               compatible = "ti,ads7830";
> +                               reg = <0x48>;
> +                       };
> +               };
> +               i2c4mux0ch7: i2c@7 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <7>;
> +
> +                       // FIO FRU
> +                       eeprom@53 {
> +                               compatible = "atmel,24c512";
> +                               reg = <0x53>;
> +                       };
> +
> +                       temperature-sensor@4b {
> +                               compatible = "ti,tmp75";
> +                               reg = <0x4b>;
> +                       };
> +
> +                       temperature-sensor@4f {
> +                               compatible = "ti,tmp75";
> +                               reg = <0x4f>;
> +                       };
> +               };
> +       };
> +};
> +
> +&i2c5 {
> +       status = "okay";
> +
> +       // E1S BP FRU
> +       eeprom@52 {
> +               compatible = "atmel,24c64";
> +               reg = <0x52>;
> +       };
> +
> +       i2c-mux@71 {
> +               compatible = "nxp,pca9546";
> +               reg = <0x71>;
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               i2c-mux-idle-disconnect;
> +
> +               i2c5mux0ch0: i2c@0 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <0>;
> +               };
> +               i2c5mux0ch1: i2c@1 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <1>;
> +               };
> +               i2c5mux0ch2: i2c@2 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <2>;
> +               };
> +               i2c5mux0ch3: i2c@3 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <3>;
> +               };
> +       };
> +
> +       i2c-mux@72 {
> +               compatible = "nxp,pca9546";
> +               reg = <0x72>;
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               i2c-mux-idle-disconnect;
> +
> +               i2c5mux1ch0: i2c@0 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <0>;
> +
> +                       voltage-sensor@48 {
> +                               compatible = "ti,ads7830";
> +                               reg = <0x48>;
> +                       };
> +               };
> +               i2c5mux1ch1: i2c@1 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <1>;
> +
> +                       temperature-sensor@48 {
> +                               compatible = "ti,tmp75";
> +                               reg = <0x48>;
> +                       };
> +               };
> +               i2c5mux1ch2: i2c@2 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <2>;
> +
> +                       power-monitor@40 {
> +                               compatible = "ti,ina230";
> +                               reg = <0x40>;
> +                               shunt-resistor = <2000>;
> +                       };
> +
> +                       power-monitor@41 {
> +                               compatible = "ti,ina230";
> +                               reg = <0x41>;
> +                               shunt-resistor = <2000>;
> +                       };
> +
> +                       power-monitor@44 {
> +                               compatible = "ti,ina230";
> +                               reg = <0x44>;
> +                               shunt-resistor = <2000>;
> +                       };
> +
> +                       power-monitor@45 {
> +                               compatible = "ti,ina230";
> +                               reg = <0x45>;
> +                               shunt-resistor = <2000>;
> +                       };
> +               };
> +               i2c5mux1ch3: i2c@3 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <3>;
> +
> +                       gpio@74 {
> +                               compatible = "nxp,pca9539";
> +                               reg = <0x74>;
> +                               gpio-controller;
> +                               #gpio-cells = <2>;
> +                               gpio-line-names =
> +                                       "P12V_E1S_ADC_ALERT","BUFF0_100M_LOSB_PLD",
> +                                       "E1S_BP_SKU_ID0","E1S_BP_SKU_ID1",
> +                                       "E1S_BP_SKU_ID2","E1S_BP_REV_ID0",
> +                                       "E1S_BP_REV_ID1","E1S_BP_REV_ID2",
> +                                       "P3V3_E1S_1_FAULT_R_N","P3V3_E1S_2_FAULT_R_N",
> +                                       "P3V3_E1S_3_FAULT_R_N","P3V3_E1S_4_FAULT_R_N",
> +                                       "P12V_E1S_1_FAULT_R_N","P12V_E1S_2_FAULT_R_N",
> +                                       "P12V_E1S_3_FAULT_R_N","P12V_E1S_4_FAULT_R_N";
> +                       };
> +               };
> +       };
> +};
> +
> +&i2c6 {
> +       status = "okay";
> +
> +       // Rainbow0 FRU
> +       eeprom@52 {
> +               compatible = "atmel,24c256";
> +               reg = <0x52>;
> +       };
> +};
> +
> +&i2c7 {
> +       status = "okay";
> +};
> +
> +&i2c8 {
> +       status = "okay";
> +
> +       // Rainbow2 FRU
> +       eeprom@52 {
> +               compatible = "atmel,24c256";
> +               reg = <0x52>;
> +       };
> +};
> +
> +&i2c9 {
> +       status = "okay";
> +
> +       // SCM FRU
> +       eeprom@50 {
> +               compatible = "atmel,24c128";
> +               reg = <0x50>;
> +       };
> +
> +       // BSM FRU
> +       eeprom@56 {
> +               compatible = "atmel,24c64";
> +               reg = <0x56>;
> +       };
> +
> +       temperature-sensor@4b {
> +               compatible = "ti,tmp75";
> +               reg = <0x4b>;
> +       };
> +};
> +
> +&i2c10 {
> +       status = "okay";
> +
> +       // Rainbow3 FRU
> +       eeprom@52 {
> +               compatible = "atmel,24c256";
> +               reg = <0x52>;
> +       };
> +};
> +
> +&i2c11 {
> +       status = "okay";
> +
> +       // OCP NIC TEMP
> +       temperature-sensor@1f {
> +               compatible = "ti,tmp421";
> +               reg = <0x1f>;
> +       };
> +
> +       // OCP NIC FRU
> +       eeprom@50 {
> +               compatible = "atmel,24c64";
> +               reg = <0x50>;
> +       };
> +};
> +
> +&i2c12 {
> +       status = "okay";
> +
> +       // SWB FRU
> +       eeprom@52 {
> +               compatible = "atmel,24c64";
> +               reg = <0x52>;
> +       };
> +
> +       i2c-mux@72 {
> +               compatible = "nxp,pca9548";
> +               reg = <0x72>;
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               i2c-mux-idle-disconnect;
> +
> +               i2c12mux0ch0: i2c@0 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <0>;
> +
> +                       temperature-sensor@48 {
> +                               compatible = "ti,tmp75";
> +                               reg = <0x48>;
> +                       };
> +               };
> +               i2c12mux0ch1: i2c@1 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <1>;
> +
> +                       power-monitor@42 {
> +                               compatible = "mps,mp2971";
> +                               reg = <0x42>;
> +                       };
> +
> +                       power-monitor@43 {
> +                               compatible = "mps,mp2971";
> +                               reg = <0x43>;
> +                       };
> +               };
> +               i2c12mux0ch2: i2c@2 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <2>;
> +
> +                       power-monitor@40 {
> +                               compatible = "ti,ina230";
> +                               reg = <0x40>;
> +                               shunt-resistor = <2000>;
> +                       };
> +
> +                       power-monitor@41 {
> +                               compatible = "ti,ina230";
> +                               reg = <0x41>;
> +                               shunt-resistor = <2000>;
> +                       };
> +               };
> +               i2c12mux0ch3: i2c@3 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <3>;
> +
> +                       power-monitor@44 {
> +                               compatible = "ti,ina230";
> +                               reg = <0x44>;
> +                               shunt-resistor = <2000>;
> +                       };
> +
> +                       power-monitor@45 {
> +                               compatible = "ti,ina230";
> +                               reg = <0x45>;
> +                               shunt-resistor = <2000>;
> +                       };
> +               };
> +               i2c12mux0ch4: i2c@4 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <4>;
> +
> +                       voltage-sensor@49 {
> +                               compatible = "ti,ads7830";
> +                               reg = <0x49>;
> +                       };
> +               };
> +               i2c12mux0ch5: i2c@5 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <5>;
> +               };
> +               i2c12mux0ch6: i2c@6 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <6>;
> +               };
> +               i2c12mux0ch7: i2c@7 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <7>;
> +               };
> +       };
> +};
> +
> +&i2c13 {
> +       status = "okay";
> +
> +       // Rainbow1 FRU
> +       eeprom@52 {
> +               compatible = "atmel,24c256";
> +               reg = <0x52>;
> +       };
> +};
> +
> +&i2c14 {
> +       status = "okay";
> +};
> +
> +&i2c15 {
> +       status = "okay";
> +};
> +
> +&adc0 {
> +       aspeed,int-vref-microvolt = <2500000>;
> +       status = "okay";
> +
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
> +               &pinctrl_adc2_default &pinctrl_adc3_default
> +               &pinctrl_adc4_default &pinctrl_adc5_default
> +               &pinctrl_adc6_default &pinctrl_adc7_default>;
> +};
> +
> +&adc1 {
> +       aspeed,int-vref-microvolt = <2500000>;
> +       status = "okay";
> +
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_adc10_default>;
> +};
> +
> +&ehci0 {
> +       status = "okay";
> +};
> +
> +&ehci1 {
> +       status = "okay";
> +};
> +
> +&gpio0 {
> +       pinctrl-names = "default";

This causes:

arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-santabarbara.dtb: gpio@...80000 (aspeed,ast2600-gpio): 'pinctrl-0' is a dependency of 'pinctrl-names'
	from schema $id: http://devicetree.org/schemas/pinctrl/pinctrl-consumer.yaml#

Please drop it.

Andrew

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ