linux-kernel - Re: [PATCH] scsi: elx: efct: fix memory leak in efct_hw_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0e84f197-169a-471c-b2e7-17de6a79f76d@flourine.local>
Date: Fri, 13 Jun 2025 09:37:22 +0200
From: Daniel Wagner <dwagner@...e.de>
To: Vitaliy Shevtsov <v.shevtsov@...integration.ru>
Cc: James Smart <james.smart@...adcom.com>, 
	Ram Vegesna <ram.vegesna@...adcom.com>, "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>, 
	"Martin K. Petersen" <martin.petersen@...cle.com>, Hannes Reinecke <hare@...e.de>, linux-scsi@...r.kernel.org, 
	target-devel@...r.kernel.org, linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] scsi: elx: efct: fix memory leak in
 efct_hw_parse_filter()

On Thu, Jun 12, 2025 at 09:35:18PM +0500, Vitaliy Shevtsov wrote:
> strsep() modifies the address of the pointer passed to it so that it no
> longer points to the original address. This means kfree() gets the wrong
> pointer.
> 
> Fix this by passing unmodified pointer returned from kstrdup() to kfree().
> 
> Found by Linux Verification Center (linuxtesting.org) with Svace.
> 
> Fixes: 4df84e846624 ("scsi: elx: efct: Driver initialization routines")
> Signed-off-by: Vitaliy Shevtsov <v.shevtsov@...integration.ru>

Reviewed-by: Daniel Wagner <dwagner@...e.de>