| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <IA3PR11MB89860787AABFDDEFC24ECDDDE577A@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Fri, 13 Jun 2025 07:52:17 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: "Lobakin, Aleksander" <aleksander.lobakin@...el.com>,
"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "Lobakin, Aleksander" <aleksander.lobakin@...el.com>, "Kubiak, Michal"
<michal.kubiak@...el.com>, "Fijalkowski, Maciej"
<maciej.fijalkowski@...el.com>, "Nguyen, Anthony L"
<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
<przemyslaw.kitszel@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "Alexei
Starovoitov" <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Jesper
Dangaard Brouer <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>,
Simon Horman <horms@...nel.org>, "nex.sw.ncis.osdt.itp.upstreaming@...el.com"
<nex.sw.ncis.osdt.itp.upstreaming@...el.com>, "bpf@...r.kernel.org"
<bpf@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v2 01/17] libeth, libie: clean
symbol exports up a little
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Alexander Lobakin
> Sent: Thursday, June 12, 2025 6:02 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: Lobakin, Aleksander <aleksander.lobakin@...el.com>; Kubiak, Michal
> <michal.kubiak@...el.com>; Fijalkowski, Maciej
> <maciej.fijalkowski@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; Andrew Lunn <andrew+netdev@...n.ch>;
> David S. Miller <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> <pabeni@...hat.com>; Alexei Starovoitov <ast@...nel.org>; Daniel
> Borkmann <daniel@...earbox.net>; Jesper Dangaard Brouer
> <hawk@...nel.org>; John Fastabend <john.fastabend@...il.com>; Simon
> Horman <horms@...nel.org>; nex.sw.ncis.osdt.itp.upstreaming@...el.com;
> bpf@...r.kernel.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [Intel-wired-lan] [PATCH iwl-next v2 01/17] libeth, libie:
> clean symbol exports up a little
>
> Change EXPORT_SYMBOL_NS_GPL(x, "LIBETH") to EXPORT_SYMBOL_GPL(x) +
> DEFAULT_SYMBOL_NAMESPACE "LIBETH" to make the code more compact.
> Also, explicitly include <linux/export.h> to satisfy new requirements
> from scripts/misc-check.
>
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@...el.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> ---
> drivers/net/ethernet/intel/libeth/rx.c | 14 +++++++++-----
> drivers/net/ethernet/intel/libie/rx.c | 7 +++++--
> 2 files changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/libeth/rx.c
> b/drivers/net/ethernet/intel/libeth/rx.c
> index 66d1d23b8ad2..c2c53552c440 100644
> --- a/drivers/net/ethernet/intel/libeth/rx.c
> +++ b/drivers/net/ethernet/intel/libeth/rx.c
> @@ -1,5 +1,9 @@
> // SPDX-License-Identifier: GPL-2.0-only
> -/* Copyright (C) 2024 Intel Corporation */
> +/* Copyright (C) 2024-2025 Intel Corporation */
> +
> +#define DEFAULT_SYMBOL_NAMESPACE "LIBETH"
> +
> +#include <linux/export.h>
>
> #include <net/libeth/rx.h>
>
> @@ -186,7 +190,7 @@ int libeth_rx_fq_create(struct libeth_fq *fq,
> struct napi_struct *napi)
>
> return -ENOMEM;
> }
> -EXPORT_SYMBOL_NS_GPL(libeth_rx_fq_create, "LIBETH");
> +EXPORT_SYMBOL_GPL(libeth_rx_fq_create);
>
> /**
> * libeth_rx_fq_destroy - destroy a &page_pool created by libeth @@ -
> 197,7 +201,7 @@ void libeth_rx_fq_destroy(struct libeth_fq *fq)
> kvfree(fq->fqes);
> page_pool_destroy(fq->pp);
> }
> -EXPORT_SYMBOL_NS_GPL(libeth_rx_fq_destroy, "LIBETH");
> +EXPORT_SYMBOL_GPL(libeth_rx_fq_destroy);
>
> /**
> * libeth_rx_recycle_slow - recycle a libeth page from the NAPI
> context @@ -209,7 +213,7 @@ void libeth_rx_recycle_slow(struct page
> *page) {
> page_pool_recycle_direct(page->pp, page); } -
> EXPORT_SYMBOL_NS_GPL(libeth_rx_recycle_slow, "LIBETH");
> +EXPORT_SYMBOL_GPL(libeth_rx_recycle_slow);
>
> /* Converting abstract packet type numbers into a software structure
> with
> * the packet parameters to do O(1) lookup on Rx.
> @@ -251,7 +255,7 @@ void libeth_rx_pt_gen_hash_type(struct
> libeth_rx_pt *pt)
> pt->hash_type |= libeth_rx_pt_xdp_iprot[pt->inner_prot];
> pt->hash_type |= libeth_rx_pt_xdp_pl[pt->payload_layer];
> }
> -EXPORT_SYMBOL_NS_GPL(libeth_rx_pt_gen_hash_type, "LIBETH");
> +EXPORT_SYMBOL_GPL(libeth_rx_pt_gen_hash_type);
>
> /* Module */
>
> diff --git a/drivers/net/ethernet/intel/libie/rx.c
> b/drivers/net/ethernet/intel/libie/rx.c
> index 66a9825fe11f..6fda656afa9c 100644
> --- a/drivers/net/ethernet/intel/libie/rx.c
> +++ b/drivers/net/ethernet/intel/libie/rx.c
> @@ -1,6 +1,9 @@
> // SPDX-License-Identifier: GPL-2.0-only
> -/* Copyright (C) 2024 Intel Corporation */
> +/* Copyright (C) 2024-2025 Intel Corporation */
>
> +#define DEFAULT_SYMBOL_NAMESPACE "LIBIE"
> +
> +#include <linux/export.h>
> #include <linux/net/intel/libie/rx.h>
>
> /* O(1) converting i40e/ice/iavf's 8/10-bit hardware packet type to a
> parsed @@ -116,7 +119,7 @@ const struct libeth_rx_pt
> libie_rx_pt_lut[LIBIE_RX_PT_NUM] = {
> LIBIE_RX_PT_IP(4),
> LIBIE_RX_PT_IP(6),
> };
> -EXPORT_SYMBOL_NS_GPL(libie_rx_pt_lut, "LIBIE");
> +EXPORT_SYMBOL_GPL(libie_rx_pt_lut);
>
> MODULE_DESCRIPTION("Intel(R) Ethernet common library");
> MODULE_IMPORT_NS("LIBETH");
> --
> 2.49.0
Powered by blists - more mailing lists