linux-kernel - Re: [PATCH 2/2] PCI/AER: Use bool for AER disable state tracking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ufdexukxobnpyjmfbr7gb2zvlv4xshkwbuinrrr3fowtmjtcyv@xfmmg7wrvjm7>
Date: Fri, 13 Jun 2025 14:15:41 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: Hans Zhang <18255117159@....com>
Cc: bhelgaas@...gle.com, tglx@...utronix.de, kw@...ux.com, 
	manivannan.sadhasivam@...aro.org, mahesh@...ux.ibm.com, oohall@...il.com, 
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, 
	Hans Zhang <hans.zhang@...tech.com>
Subject: Re: [PATCH 2/2] PCI/AER: Use bool for AER disable state tracking

On Sat, May 17, 2025 at 12:52:23AM +0800, Hans Zhang wrote:
> From: Hans Zhang <hans.zhang@...tech.com>
> 
> Change pcie_aer_disable variable to bool and update pci_no_aer()
> to set it to true. Improves code readability and aligns with modern
> kernel practices.
> 
> Signed-off-by: Hans Zhang <hans.zhang@...tech.com>

Applied to pci/misc!

- Mani

> ---
>  drivers/pci/pcie/aer.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> index a1cf8c7ef628..ade98c5a19b9 100644
> --- a/drivers/pci/pcie/aer.c
> +++ b/drivers/pci/pcie/aer.c
> @@ -111,12 +111,12 @@ struct aer_stats {
>  					PCI_ERR_ROOT_MULTI_COR_RCV |	\
>  					PCI_ERR_ROOT_MULTI_UNCOR_RCV)
>  
> -static int pcie_aer_disable;
> +static bool pcie_aer_disable;
>  static pci_ers_result_t aer_root_reset(struct pci_dev *dev);
>  
>  void pci_no_aer(void)
>  {
> -	pcie_aer_disable = 1;
> +	pcie_aer_disable = true;
>  }
>  
>  bool pci_aer_available(void)
> -- 
> 2.25.1
> 

-- 
மணிவண்ணன் சதாசிவம்