linux-kernel - Re: [PATCH] platform/x86/intel-uncore-freq: avoid non-literal format string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174980450175.1640.12062242383746628445.b4-ty@linux.intel.com>
Date: Fri, 13 Jun 2025 11:48:21 +0300
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>, 
 Hans de Goede <hansg@...nel.org>, Arnd Bergmann <arnd@...nel.org>
Cc: Arnd Bergmann <arnd@...db.de>, 
 Tero Kristo <tero.kristo@...ux.intel.com>, 
 Peter Zijlstra <peterz@...radead.org>, platform-driver-x86@...r.kernel.org, 
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86/intel-uncore-freq: avoid non-literal
 format string

On Tue, 10 Jun 2025 11:34:55 +0200, Arnd Bergmann wrote:

> Using a string variable in place of a format string causes a W=1 build warning:
> 
> drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c:61:40: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
>    61 |                 length += sysfs_emit_at(buf, length, agent_name[agent]);
>       |                                                      ^~~~~~~~~~~~~~~~~
> 
> Use the safer "%s" format string to print it instead.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86/intel-uncore-freq: avoid non-literal format string
      commit: 0c44b46f51a17baa7ab67de1464427116e9c4eaa

--
 i.