linux-kernel - Re: [PATCHv2 1/2] sched/wait: Add wait_event_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250613091713.GD2278213@noisy.programming.kicks-ass.net>
Date: Fri, 13 Jun 2025 11:17:13 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Sergey Senozhatsky <senozhatsky@...omium.org>
Cc: Miklos Szeredi <miklos@...redi.hu>, Ingo Molnar <mingo@...hat.com>,
	Juri Lelli <juri.lelli@...hat.com>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ben Segall <bsegall@...gle.com>, Tomasz Figa <tfiga@...omium.org>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 1/2] sched/wait: Add wait_event_state_exclusive()

On Tue, Jun 10, 2025 at 01:52:28PM +0900, Sergey Senozhatsky wrote:
> Allows exclusive waits with a custom @state.
> 
> Signed-off-by: Sergey Senozhatsky <senozhatsky@...omium.org>

Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>

> ---
> 
> v2: switched to wait_event_state_exclusive()
> 
>  include/linux/wait.h | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/include/linux/wait.h b/include/linux/wait.h
> index 327894f022cf..9ebb0d2e422a 100644
> --- a/include/linux/wait.h
> +++ b/include/linux/wait.h
> @@ -968,6 +968,18 @@ extern int do_wait_intr_irq(wait_queue_head_t *, wait_queue_entry_t *);
>  		      state, 0, timeout,					\
>  		      __ret = schedule_timeout(__ret))
>  
> +#define __wait_event_state_exclusive(wq, condition, state)			\
> +	___wait_event(wq, condition, state, 1, 0, schedule())
> +
> +#define wait_event_state_exclusive(wq, condition, state)			\
> +({										\
> +	int __ret = 0;								\
> +	might_sleep();								\
> +	if (!(condition))							\
> +		__ret = __wait_event_state_exclusive(wq, condition, state);	\
> +	__ret;									\
> +})
> +
>  #define __wait_event_killable_timeout(wq_head, condition, timeout)		\
>  	___wait_event(wq_head, ___wait_cond_timeout(condition),			\
>  		      TASK_KILLABLE, 0, timeout,				\
> -- 
> 2.50.0.rc1.591.g9c95f17f64-goog
>