linux-kernel - Re: [PATCH] pci: altera: remove unused 'node' variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <174980672103.33830.4953083744774912018.b4-ty@kernel.org>
Date: Fri, 13 Jun 2025 14:55:28 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: Thomas Gleixner <tglx@...utronix.de>,
	Arnd Bergmann <arnd@...nel.org>
Cc: Manivannan Sadhasivam <mani@...nel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Joyce Ooi <joyce.ooi@...el.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	"Jiri Slaby (SUSE)" <jirislaby@...nel.org>,
	linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pci: altera: remove unused 'node' variable


On Wed, 21 May 2025 18:29:48 +0200, Arnd Bergmann wrote:
> This variable is only used when CONFIG_OF is enabled:
> 
> drivers/pci/controller/pcie-altera.c: In function 'altera_pcie_init_irq_domain':
> drivers/pci/controller/pcie-altera.c:855:29: error: unused variable 'node' [-Werror=unused-variable]
>   855 |         struct device_node *node = dev->of_node;
> 
> Use dev_fwnode() in place of of_node_to_fwnode() to avoid this.
> 
> [...]

Applied, thanks!

[1/1] pci: altera: remove unused 'node' variable
      commit: 693594d0e5d8d236fc4172c864afdcbe6993a2bd

Best regards,
-- 
Manivannan Sadhasivam <mani@...nel.org>