linux-kernel - Re: [PATCH] exfat: fdatasync flag should be same like generic_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PUZPR04MB6316E8048064CB15DACDDE1B8177A@PUZPR04MB6316.apcprd04.prod.outlook.com>
Date: Fri, 13 Jun 2025 10:13:55 +0000
From: "Yuezhang.Mo@...y.com" <Yuezhang.Mo@...y.com>
To: Cixi Geng <cixi.geng@...ux.dev>,
        "linkinjeon@...nel.org"
	<linkinjeon@...nel.org>,
        "sj1557.seo@...sung.com" <sj1557.seo@...sung.com>
CC: "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "zhengxu.zhang@...soc.com" <zhengxu.zhang@...soc.com>
Subject: Re: [PATCH] exfat: fdatasync flag should be same like
 generic_write_sync()

> generic_file_write_iter(), when calling generic_rite_sync() and

s/_rite/_write

> --- a/fs/exfat/file.c
> +++ b/fs/exfat/file.c
> @@ -625,7 +625,7 @@ static ssize_t exfat_file_write_iter(struct kiocb *iocb, struct iov_iter *iter)
> 
>        if (iocb_is_dsync(iocb) && iocb->ki_pos > pos) {
>                 ssize_t err = vfs_fsync_range(file, pos, iocb->ki_pos - 1,
> -                               iocb->ki_flags & IOCB_SYNC);
> +                               (iocb->ki_flags & IOCB_SYNC) ? 0 : 1);

How about calling generic_write_sync() instead of vfs_fsync_range(), like in 
generic_file_write_iter()?