linux-kernel - Re: [PATCH v5 3/9] arm64: dts: freescale: rename imx93.dtsi to imx91_93

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e8f2426-92a1-4c7e-b860-0e10e8dd886c@kernel.org>
Date: Fri, 13 Jun 2025 12:43:01 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Joy Zou <joy.zou@....com>, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
 catalin.marinas@....com, will@...nel.org, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com,
 ulf.hansson@...aro.org, richardcochran@...il.com, kernel@...gutronix.de,
 festevam@...il.com
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
 linux-pm@...r.kernel.org, frank.li@....com, ye.li@....com, ping.bai@....com,
 peng.fan@....com, aisheng.dong@....com, xiaoning.wang@....com
Subject: Re: [PATCH v5 3/9] arm64: dts: freescale: rename imx93.dtsi to
 imx91_93_common.dtsi

On 13/06/2025 12:02, Joy Zou wrote:
> Rename imx93.dtsi to imx91_93_common.dtsi for adding imx91.dtsi.

Why?

Your commit msg MUST explain that. That's the more important part.

> There is no code change.
> 
> Add imx93.dtsi, which include imx91_93_common.dtsi.
> 
> Signed-off-by: Joy Zou <joy.zou@....com>
> ---
>  .../boot/dts/freescale/imx91_93_common.dtsi   | 1351 +++++++++++++++++
>  arch/arm64/boot/dts/freescale/imx93.dtsi      | 1349 +---------------

Generate patches with proper -M/-B/-C flags so it will be possible to
actually review this.


>  2 files changed, 1353 insertions(+), 1347 deletions(-)
>  create mode 100644 arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi b/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
> new file mode 100644
> index 000000000000..64cd0776b43d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
> @@ -0,0 +1,1351 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright 2022 NXP
> + */
> +
> +#include <dt-bindings/clock/imx93-clock.h>
> +#include <dt-bindings/dma/fsl-edma.h>
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/power/fsl,imx93-power.h>
> +#include <dt-bindings/thermal/thermal.h>
> +
> +#include "imx93-pinfunc.h"
> +
> +/ {
> +	interrupt-parent = <&gic>;
> +	#address-cells = <2>;
> +	#size-cells = <2>;
> +
> +	aliases {
> +		gpio0 = &gpio1;
> +		gpio1 = &gpio2;
> +		gpio2 = &gpio3;
> +		gpio3 = &gpio4;
> +		i2c0 = &lpi2c1;
> +		i2c1 = &lpi2c2;
> +		i2c2 = &lpi2c3;
> +		i2c3 = &lpi2c4;
> +		i2c4 = &lpi2c5;
> +		i2c5 = &lpi2c6;
> +		i2c6 = &lpi2c7;
> +		i2c7 = &lpi2c8;

Not common aliases. Drop.


> +		mmc0 = &usdhc1;
> +		mmc1 = &usdhc2;
> +		mmc2 = &usdhc3;

Not common aliases. Drop.


> +		serial0 = &lpuart1;
> +		serial1 = &lpuart2;
> +		serial2 = &lpuart3;
> +		serial3 = &lpuart4;
> +		serial4 = &lpuart5;
> +		serial5 = &lpuart6;
> +		serial6 = &lpuart7;
> +		serial7 = &lpuart8;

Not common aliases. Drop.

> +		spi0 = &lpspi1;
> +		spi1 = &lpspi2;
> +		spi2 = &lpspi3;
> +		spi3 = &lpspi4;
> +		spi4 = &lpspi5;
> +		spi5 = &lpspi6;
> +		spi6 = &lpspi7;
> +		spi7 = &lpspi8;

Not common aliases. Drop.


Best regards,
Krzysztof