linux-kernel - Re: [PATCH v2] nfsd: Implement large extent array support in pNFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <xr7sopuwurexwjcvcm2iaikv7yax45ryqxdpjyipcv7obph62i@xbdkqwznujsn>
Date: Fri, 13 Jun 2025 15:01:57 +0300
From: Sergey Bashirov <sergeybashirov@...il.com>
To: Chuck Lever <chuck.lever@...cle.com>
Cc: Christoph Hellwig <hch@...radead.org>, 
	Jeff Layton <jlayton@...nel.org>, NeilBrown <neil@...wn.name>, 
	Olga Kornievskaia <okorniev@...hat.com>, Dai Ngo <Dai.Ngo@...cle.com>, Tom Talpey <tom@...pey.com>, 
	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Konstantin Evtushenko <koevtushenko@...dex.com>
Subject: Re: [PATCH v2] nfsd: Implement large extent array support in pNFS

On Tue, Jun 10, 2025 at 02:10:46PM -0400, Chuck Lever wrote:
> On 6/9/25 9:18 PM, Sergey Bashirov wrote:
> > +	xdr_init_decode(&xdr, buf, buf->head[0].iov_base, NULL);
> > +	xdr_set_scratch_buffer(&xdr, scratch, sizeof(scratch));
>
> Consider using svcxdr_init_decode() instead.

I see that svcxdr_init_decode() does the same two steps. What I
concerned about is that it takes the top-level svc_rqst struct
and modifies it. Of course, we can pass rqstp from nfsd4_layoutcommit()
to the layout driver callback. But then we would need to make a backup
of the original xdr buffer and stream position, set up and initialize
the xdr sub-buffer, and at the end restore back the original xdr stream.
All these actions seem somewhat unnecessary and not so elegant to me.

Is it acceptable to keep the current solution in the patch or am I
missing something?

--
Sergey Bashirov