linux-kernel - Re: [PATCH] platform/x86: portwell-ec: Move watchdog device under correct platform hierarchy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <18d60b6c-80c0-85e8-79f5-a41d8a757a46@linux.intel.com>
Date: Fri, 13 Jun 2025 15:08:13 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Ivan Hu <ivan.hu@...onical.com>
cc: Hans de Goede <hdegoede@...hat.com>, jesse.huang@...twell.com.tw, 
    platform-driver-x86@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: portwell-ec: Move watchdog device under
 correct platform hierarchy

On Fri, 13 Jun 2025, Ivan Hu wrote:

> Without explicitly setting a parent for the watchdog device, the device is
> registered with a NULL parent. This causes device_add() (called internally
> by devm_watchdog_register_device()) to register the device under
> /sys/devices/virtual, since no parent is provided. The result is:
> 
> DEVPATH=/devices/virtual/watchdog/watchdog0
> 
> To fix this, assign &pdev->dev as the parent of the watchdog device before
> calling devm_watchdog_register_device(). This ensures the device is
> associated with the Portwell EC platform device and placed correctly in
> sysfs as:
> 
> DEVPATH=/devices/platform/portwell-ec/watchdog/watchdog0
> 
> This aligns the device hierarchy with expectations and avoids misplacement
> under the virtual class.
> 

This is missing the Fixes tag.

> Signed-off-by: Ivan Hu <ivan.hu@...onical.com>
> ---
>  drivers/platform/x86/portwell-ec.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/portwell-ec.c b/drivers/platform/x86/portwell-ec.c
> index 8b788822237b..3e019c51913e 100644
> --- a/drivers/platform/x86/portwell-ec.c
> +++ b/drivers/platform/x86/portwell-ec.c
> @@ -236,6 +236,7 @@ static int pwec_probe(struct platform_device *pdev)
>  		return ret;
>  	}
>  
> +	ec_wdt_dev.parent = &pdev->dev;
>  	ret = devm_watchdog_register_device(&pdev->dev, &ec_wdt_dev);
>  	if (ret < 0) {
>  		dev_err(&pdev->dev, "failed to register Portwell EC Watchdog\n");
> 

-- 
 i.