linux-kernel - [RFC PATCH] mfd: twl4030-irq: remove redundant 'node' variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250613122251.1033078-1-abinashsinghlalotra@gmail.com>
Date: Fri, 13 Jun 2025 17:52:51 +0530
From: avinashlalotra <abinashlalotra@...il.com>
To: linux-omap@...r.kernel.org
Cc: linux-kernel@...r.kernel.org,
	aaro.koskinen@....fi,
	andreas@...nade.info,
	khilman@...libre.com,
	rogerq@...nel.org,
	tony@...mide.com,
	lee@...nel.org,
	avinashlalotra <abinashsinghlalotra@...il.com>
Subject: [RFC PATCH] mfd: twl4030-irq: remove redundant 'node' variable

The local variable 'node' was used only once to retrieve dev->of_node
in a call to irq_domain_create_legacy(). This patch inlines the usage
and removes the redundant variable, improving code clarity.

No functional change intended.

Signed-off-by: avinashlalotra <abinashsinghlalotra@...il.com>
---
 drivers/mfd/twl4030-irq.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
index 232c2bfe8c18..a2ab5deef9e2 100644
--- a/drivers/mfd/twl4030-irq.c
+++ b/drivers/mfd/twl4030-irq.c
@@ -676,7 +676,6 @@ int twl4030_init_irq(struct device *dev, int irq_num)
 	static struct irq_chip	twl4030_irq_chip;
 	int			status, i;
 	int			irq_base, irq_end, nr_irqs;
-	struct			device_node *node = dev->of_node;
 
 	/*
 	 * TWL core and pwr interrupts must be contiguous because
@@ -691,7 +690,7 @@ int twl4030_init_irq(struct device *dev, int irq_num)
 		return irq_base;
 	}
 
-	irq_domain_create_legacy(of_fwnode_handle(node), nr_irqs, irq_base, 0,
+	irq_domain_create_legacy(of_fwnode_handle(dev->of_node), nr_irqs, irq_base, 0,
 				 &irq_domain_simple_ops, NULL);
 
 	irq_end = irq_base + TWL4030_CORE_NR_IRQS;
-- 
2.43.0