linux-kernel - Re: [PATCH v11 10/11] iio: adc: ad7768-1: add filter type and oversampling ratio attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEwdP9Tu4TvguUmI@smile.fi.intel.com>
Date: Fri, 13 Jun 2025 15:44:47 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Jonathan Santos <Jonathan.Santos@...log.com>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
	andy@...nel.org, nuno.sa@...log.com, Michael.Hennerich@...log.com,
	marcelo.schmitt@...log.com, jic23@...nel.org, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, marcelo.schmitt1@...il.com,
	linus.walleij@...aro.org, brgl@...ev.pl, lgirdwood@...il.com,
	broonie@...nel.org, jonath4nns@...il.com, dlechner@...libre.com,
	Pop Paul <paul.pop@...log.com>
Subject: Re: [PATCH v11 10/11] iio: adc: ad7768-1: add filter type and
 oversampling ratio attributes

On Wed, Jun 11, 2025 at 08:51:50AM -0300, Jonathan Santos wrote:
> Separate filter type and decimation rate from the sampling frequency
> attribute. The new filter type attribute enables sinc3, sinc3+rej60
> and wideband filters, which were previously unavailable.
> 
> Previously, combining decimation and MCLK divider in the sampling
> frequency obscured performance trade-offs. Lower MCLK divider
> settings increase power usage, while lower decimation rates reduce
> precision by decreasing averaging. By creating an oversampling
> attribute, which controls the decimation, users gain finer control
> over performance.
> 
> The addition of those attributes allows a wider range of sampling
> frequencies and more access to the device features. Sampling frequency
> table is updated after every digital filter parameter change.
> 
> Changes in the sampling frequency are not allowed anymore while in
> buffered mode.

...

> +	/*
> +	 * The SINC3_DEC_RATE value is a 13-bit value split across two
> +	 * registers: MSB [12:8] and LSB [7:0]. Prepare the 13-bit value using
> +	 * FIELD_PREP and store it with the right endianness in dec_rate_reg.

FIELD_PREP()

> +	 */

-- 
With Best Regards,
Andy Shevchenko