linux-kernel - Re: [PATCH v3 0/6] sysfs: finalize the constification of 'struct bin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa9b1cb8-28a7-4ae0-89c8-8e3f9f149c56@t-8ch.de>
Date: Sat, 14 Jun 2025 08:23:24 +0200
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, 
	Danilo Krummrich <dakr@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/6] sysfs: finalize the constification of 'struct
 bin_attribute'

Hi Greg,

friendly ping. You wanted to send this to Linux at around -rc1.
The changes should now apply cleanly to mainline.

On 2025-05-30 05:54:34+0200, Thomas Weißschuh wrote:
> All users have been migrated to the new const types.
> Change the types of the normal fields, switch all users over and then
> get rid of the transition machinery.
> 
> The treewide changes have been done with sed/grep.
> Based on top of next-20250528.
> Meant to be applied around the end of the merge window.
> As it is not clear what goes into the merge window this is done on
> linux-next. Applying it will probably create some trivially to resolve
> conflicts.
> 
> After applying, make sure no leftovers are left:
> $ git grep bin_attrs_new
> $ git grep read_new ':!drivers/block/swim_asm.S'
> $ git grep write_new ':!drivers/cpufreq/powernow-k8.c' ':!drivers/s390/char/monwriter.c'
> 
> I'm only sending this to the sysfs maintainers. The treewide changes are
> purely mechanical.
> 
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> ---
> Changes in v3:
> - Drop already applied patches
> - Constify internal references in fs/sysfs/file.c
> - Update const_structs.checkpatch
> - Rebase on linux-next/master
> - Link to v2: https://lore.kernel.org/r/20250313-sysfs-const-bin_attr-final-v2-0-96284e1e88ce@weissschuh.net
> 
> Changes in v2:
> - Rebase onto current driver-core-next.
> - Remove prerequisites list from cover letter.
> - Link to v1: https://lore.kernel.org/r/20250219-sysfs-const-bin_attr-final-v1-0-02828d86af3c@weissschuh.net
> 
> ---
> Thomas Weißschuh (6):
>       const_structs.checkpatch: add bin_attribute
>       sysfs: constify internal references to 'struct bin_attribute'
>       sysfs: treewide: switch back to bin_attribute::read()/write()
>       sysfs: treewide: switch back to attribute_group::bin_attrs
>       sysfs: remove bin_attribute::read_new/write_new()
>       sysfs: remove attribute_group::bin_attrs_new

<snip>