linux-kernel - [PATCH] x86/kconfig/defconfig: Enable CONFIG_DRM_FBDEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aE0lfuuzXkVNxtKO@gmail.com>
Date: Sat, 14 Jun 2025 09:32:14 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Vitaly Kuznetsov <vkuznets@...hat.com>
Cc: Michael Kelley <mhklinux@...look.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"H . Peter Anvin" <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Borislav Petkov <bp@...en8.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	Jürgen Groß <jgross@...e.com>,
	"Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
	Ard Biesheuvel <ardb@...nel.org>, Arnd Bergmann <arnd@...db.de>,
	Carlos Bilbao <carlos.bilbao@...nel.org>,
	David Woodhouse <dwmw@...zon.co.uk>,
	Elena Reshetova <elena.reshetova@...el.com>,
	Fei Li <fei1.li@...el.com>, Jan Kiszka <jan.kiszka@...mens.com>,
	Masahiro Yamada <yamada.masahiro@...ionext.com>,
	Michal Marek <michal.lkml@...kovi.net>,
	Paolo Bonzini <pbonzini@...hat.com>,
	Sean Christopherson <seanjc@...gle.com>,
	Stefano Stabellini <sstabellini@...nel.org>
Subject: [PATCH] x86/kconfig/defconfig: Enable CONFIG_DRM_FBDEV_EMULATION=y


* Vitaly Kuznetsov <vkuznets@...hat.com> wrote:

> Michael Kelley <mhklinux@...look.com> writes:
> 
> > From: Ingo Molnar <mingo@...nel.org> Sent: Thursday, May 15, 2025 6:27 AM
> >> 
> >> Since the x86 defconfig aims to be a distro kernel work-alike with
> >> fewer drivers and a shorter build time, refresh all the virtualization
> >> guest Kconfig features, enabling paravirt spinlocks, and
> >> enabling the guest support code for the following guests:
> >> 
> >>  - Xen
> >>  - Xen_PVH
> >>  - Jailhouse
> >>  - ACRN
> >>  - Intel TDX
> >>  - Hyper-V
> >
> > I built and tested a Hyper-V guest with defconfig. The Hyper-V storage
> > and keyboard drivers are pulled in automatically, so my previous
> > comment about them being "missing" is moot.
> >
> > But the Linux console for each Hyper-V guest is a synthetic graphics
> > console, and that didn't work with the DRM_HYPERV driver. Missing
> > the console pretty much kills any usefulness. DRM doesn't have 
> > Linux console support, so it needs CONFIG_DRM_FBDEV_EMULATION
> > to be set, and defconfig doesn't have it.
> >
> > So either CONFIG_DRM_FBDEV_EMULATION needs to be added, or
> > defconfig should switch to the older HYPERV_FB driver. I think we'd
> > rather do the former. Vitaly -- any thoughts?
> >
> 
> Yea, my vote goes to the same option: let's enable
> CONFIG_DRM_FBDEV_EMULATION.

Okay - I've addressed the enabling of this option separately in:

    7ce421edd9fc ("x86/kconfig/defconfig: Enable CONFIG_DRM_FBDEV_EMULATION=y")

Also attached below.

Thanks,

	Ingo

=======================>
From: Ingo Molnar <mingo@...nel.org>
Date: Sat, 14 Jun 2025 09:10:55 +0200
Subject: [PATCH] x86/kconfig/defconfig: Enable CONFIG_DRM_FBDEV_EMULATION=y

Michael Kelley reported that the x86 defconfig *almost* works
well on Hyper-V guests out of box, with the exception of
console support:

 > I built and tested a Hyper-V guest with defconfig. The Hyper-V storage
 > and keyboard drivers are pulled in automatically. [...]
 >
 > But the Linux console for each Hyper-V guest is a synthetic graphics
 > console, and that didn't work with the DRM_HYPERV driver. Missing
 > the console pretty much kills any usefulness. DRM doesn't have
 > Linux console support, so it needs CONFIG_DRM_FBDEV_EMULATION
 > to be set, and defconfig doesn't have it.

So enable CONFIG_DRM_FBDEV_EMULATION.

Also enable the dependent CONFIG_FRAMEBUFFER_CONSOLE_ROTATION option
(disabled by default), as all major Linux distros have it enabled,
probably as a sysadmin quality-of-life option:

	.config.distro.debian.x86_32:     CONFIG_FRAMEBUFFER_CONSOLE_ROTATION=y
	.config.distro.fedora.generic:    CONFIG_FRAMEBUFFER_CONSOLE_ROTATION=y
	.config.distro.opensuse.default:  CONFIG_FRAMEBUFFER_CONSOLE_ROTATION=y
	.config.distro.rhel.generic:      CONFIG_FRAMEBUFFER_CONSOLE_ROTATION=y
	.config.distro.ubuntu:            CONFIG_FRAMEBUFFER_CONSOLE_ROTATION=y

There's no measurable build time impact within ~1% stddev:

  $ perf stat --null --repeat 3 --sync --pre='make clean >/dev/null' make -j128 bzImage >/dev/null

  Performance counter stats for 'make -j128 bzImage' (3 runs):

  # before:         33.759 +- 0.286 seconds time elapsed  ( +-  0.85% )
  # after:          33.593 +- 0.314 seconds time elapsed  ( +-  0.94% )

Suggested-by: Michael Kelley <mhklinux@...look.com>
Signed-off-by: Ingo Molnar <mingo@...nel.org>
Acked-by: Vitaly Kuznetsov <vkuznets@...hat.com>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Ard Biesheuvel <ardb@...nel.org>
Cc: Arnd Bergmann <arnd@...db.de>
Cc: David Woodhouse <dwmw@...zon.co.uk>
Cc: H. Peter Anvin <hpa@...or.com>
Cc: Jürgen Groß <jgross@...e.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc: Michal Marek <michal.lkml@...kovi.net>
Cc: linux-kernel@...r.kernel.org
Link: https://lore.kernel.org/r/SN6PR02MB4157B1676A6284ECD21E494FD490A@SN6PR02MB4157.namprd02.prod.outlook.com # Discussion
---
 arch/x86/configs/i386_defconfig   | 2 ++
 arch/x86/configs/x86_64_defconfig | 3 +++
 2 files changed, 5 insertions(+)

diff --git a/arch/x86/configs/i386_defconfig b/arch/x86/configs/i386_defconfig
index aeba95893086..39a660d71a0a 100644
--- a/arch/x86/configs/i386_defconfig
+++ b/arch/x86/configs/i386_defconfig
@@ -239,8 +239,10 @@ CONFIG_AGP=y
 CONFIG_AGP_AMD64=y
 CONFIG_AGP_INTEL=y
 CONFIG_DRM=y
+CONFIG_DRM_FBDEV_EMULATION=y
 CONFIG_DRM_VIRTIO_GPU=y
 CONFIG_DRM_HYPERV=y
+CONFIG_FRAMEBUFFER_CONSOLE_ROTATION=y
 CONFIG_SOUND=y
 CONFIG_SND=y
 CONFIG_SND_HRTIMER=y
diff --git a/arch/x86/configs/x86_64_defconfig b/arch/x86/configs/x86_64_defconfig
index c20100d77387..b5dc26fb715a 100644
--- a/arch/x86/configs/x86_64_defconfig
+++ b/arch/x86/configs/x86_64_defconfig
@@ -116,6 +116,7 @@ CONFIG_ANON_VMA_NAME=y
 CONFIG_USERFAULTFD=y
 CONFIG_LRU_GEN=y
 CONFIG_LRU_GEN_ENABLED=y
+# CONFIG_DAMON is not set
 CONFIG_NET=y
 CONFIG_PACKET=y
 CONFIG_XFRM_USER=y
@@ -248,8 +249,10 @@ CONFIG_AGP=y
 CONFIG_AGP_AMD64=y
 CONFIG_AGP_INTEL=y
 CONFIG_DRM=y
+CONFIG_DRM_FBDEV_EMULATION=y
 CONFIG_DRM_VIRTIO_GPU=y
 CONFIG_DRM_HYPERV=y
+CONFIG_FRAMEBUFFER_CONSOLE_ROTATION=y
 CONFIG_SOUND=y
 CONFIG_SND=y
 CONFIG_SND_HRTIMER=y