linux-kernel - Re: [PATCH] driver core: faux: fix Undefined Behavior in faux_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250614105037.1441029-1-ojeda@kernel.org>
Date: Sat, 14 Jun 2025 12:50:37 +0200
From: Miguel Ojeda <ojeda@...nel.org>
To: gregkh@...uxfoundation.org
Cc: Benjamin.Cheatham@....com,
	Jonathan.Cameron@...wei.com,
	dakr@...nel.org,
	dan.j.williams@...el.com,
	linux-acpi@...r.kernel.org,
	linux-cxl@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	marc.herbert@...ux.intel.com,
	rafael.j.wysocki@...el.com,
	rafael@...nel.org,
	sudeep.holla@....com,
	Dan Carpenter <dan.carpenter@...aro.org>,
	Kees Cook <kees@...nel.org>
Subject: Re: [PATCH] driver core: faux: fix Undefined Behavior in faux_device_destroy()

On Fri, 13 Jun 2025 20:33:42 -0400 Greg KH <gregkh@...uxfoundation.org> wrote:
>
> Great writeup, but as Miguel says, this isn't needed at all, the kernel
> relies on the compiler to be sane :)

We may still want to clean them up, e.g. for tooling -- Kees/Dan: do we?
e.g. I see a similar case with discussion at:

    https://lore.kernel.org/lkml/3f1e7aaa-501a-44f1-8122-28e9efa0a33c@web.de/

Which in the end was picked up as commit 2df2c0caaecf ("fbdev: au1100fb:
Move a variable assignment behind a null pointer check").

Cheers,
Miguel