[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250614142704.3c07e453@jic23-huawei>
Date: Sat, 14 Jun 2025 14:27:04 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: <victor.duicu@...rochip.com>
Cc: <dlechner@...libre.com>, <nuno.sa@...log.com>, <andy@...nel.org>,
<robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
<marius.cristea@...rochip.com>, <linux-iio@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] iio: temperature: add support for MCP998X
>
> > +
> > +static const struct i2c_device_id mcp9982_id[] = {
> > + { .name = "mcp9933", .driver_data = (kernel_ulong_t)&mcp9933_chip_config },
> > + { .name = "mcp9933d", .driver_data = (kernel_ulong_t)&mcp9933d_chip_config },
> > + { .name = "mcp9982", .driver_data = (kernel_ulong_t)&mcp9982_chip_config },
> > + { .name = "mcp9982d", .driver_data = (kernel_ulong_t)&mcp9982d_chip_config },
> > + { .name = "mcp9983", .driver_data = (kernel_ulong_t)&mcp9983_chip_config },
> > + { .name = "mcp9983d", .driver_data = (kernel_ulong_t)&mcp9983d_chip_config },
> > + { .name = "mcp9984", .driver_data = (kernel_ulong_t)&mcp9984_chip_config },
> > + { .name = "mcp9984d", .driver_data = (kernel_ulong_t)&mcp9984d_chip_config },
> > + { .name = "mcp9985", .driver_data = (kernel_ulong_t)&mcp9985_chip_config },
> > + { .name = "mcp9985d", .driver_data = (kernel_ulong_t)&mcp9985d_chip_config },
> > + { }
> David mentioned the other day that there is an effort to remove the need for
> the kernel_ulong_t here but it relies on
> { "mcp9985d", &mcp9984d_chip_config },
> style entries.
Oops. Still need the cast.
>
> https://lore.kernel.org/all/1c7946f1-d712-4baa-8243-be6a55eec528@baylibre.com/
>
> I wasn't aware of that effort but seems sensible to me!
>
>
> > +};
> > +MODULE_DEVICE_TABLE(i2c, mcp9982_id);
>
>
Powered by blists - more mailing lists