linux-kernel - Re: [PATCH v2 05/12] tools: ynl_gen_rst.py: Split library from command line tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD4GDZwJtrL3uRCXNJ9vdfXAnjL4H5nhSqn3GDSW90Ee22qgGA@mail.gmail.com>
Date: Sat, 14 Jun 2025 14:34:01 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc: Jonathan Corbet <corbet@....net>, Linux Doc Mailing List <linux-doc@...r.kernel.org>, 
	Akira Yokosawa <akiyks@...il.com>, Breno Leitao <leitao@...ian.org>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Ignacio Encinas Rubio <ignacio@...cinas.com>, Jan Stancek <jstancek@...hat.com>, 
	Marco Elver <elver@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Ruben Wauters <rubenru09@....com>, 
	Shuah Khan <skhan@...uxfoundation.org>, joel@...lfernandes.org, 
	linux-kernel-mentees@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	lkmm@...ts.linux.dev, netdev@...r.kernel.org, peterz@...radead.org, 
	stern@...land.harvard.edu
Subject: Re: [PATCH v2 05/12] tools: ynl_gen_rst.py: Split library from
 command line tool

On Fri, 13 Jun 2025 at 13:18, Mauro Carvalho Chehab
<mchehab+huawei@...nel.org> wrote:
>
> Em Fri, 13 Jun 2025 12:13:28 +0100
> Donald Hunter <donald.hunter@...il.com> escreveu:
>
> > Mauro Carvalho Chehab <mchehab+huawei@...nel.org> writes:
> >
> > > As we'll be using the Netlink specs parser inside a Sphinx
> > > extension, move the library part from the command line parser.
> > >
> > > No functional changes.
> > >
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> > > ---
> > >  scripts/lib/netlink_yml_parser.py  | 391 +++++++++++++++++++++++++++++
> > >  tools/net/ynl/pyynl/ynl_gen_rst.py | 374 +--------------------------
> >
> > I think the library code should be put in tools/net/ynl/pyynl/lib
> > because it is YNL specific code. Maybe call it rst_generator.py
>
> We had a similar discussion before when we switched get_abi and
> kernel-doc to Python. On that time, we opted to place all shared
> Python libraries under scripts/lib.
>
> From my side, I don't mind having them on a different place,
> but I prefer to see all Sphinx extensions getting libraries from
> the same base directory.

It's YNL specific code and I want to refactor it to make use of
tools/net/ynl/pyynl/lib/nlspec.py so it definitely belongs in
tools/net/ynl/pyynl/lib.

> Jon,
>
> What do you think?
>
> Thanks,
> Mauro