linux-kernel - Re: [PATCH v9 06/11] iio: accel: adxl345: replace magic numbers by unit expressions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250614144914.3ad824ef@jic23-huawei>
Date: Sat, 14 Jun 2025 14:49:14 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Lothar Rubusch <l.rubusch@...il.com>
Cc: lars@...afoo.de, Michael.Hennerich@...log.com, dlechner@...libre.com,
 nuno.sa@...log.com, andy@...nel.org, corbet@....net,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, eraretuya@...il.com
Subject: Re: [PATCH v9 06/11] iio: accel: adxl345: replace magic numbers by
 unit expressions

On Tue, 10 Jun 2025 21:59:28 +0000
Lothar Rubusch <l.rubusch@...il.com> wrote:

> Replace absolute numbers by their expressions from units.h to avoid
> using magic numbers. Use uniform expressions to clarify their usage.
> 
> This is a refactoring change and should not impact functionality.
> 
> Signed-off-by: Lothar Rubusch <l.rubusch@...il.com>
Nice. Applied with a little fuzz due to the earlier patches that I haven't
picked up yet.

Thanks,

J
> ---
>  drivers/iio/accel/adxl345_core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/accel/adxl345_core.c b/drivers/iio/accel/adxl345_core.c
> index dcfbfe4cac0f..2c4f045c741c 100644
> --- a/drivers/iio/accel/adxl345_core.c
> +++ b/drivers/iio/accel/adxl345_core.c
> @@ -706,15 +706,15 @@ static int adxl345_read_event_value(struct iio_dev *indio_dev,
>  			return IIO_VAL_FRACTIONAL;
>  		case IIO_EV_INFO_TIMEOUT:
>  			*val = st->tap_duration_us;
> -			*val2 = 1000000;
> +			*val2 = MICRO;
>  			return IIO_VAL_FRACTIONAL;
>  		case IIO_EV_INFO_RESET_TIMEOUT:
>  			*val = st->tap_window_us;
> -			*val2 = 1000000;
> +			*val2 = MICRO;
>  			return IIO_VAL_FRACTIONAL;
>  		case IIO_EV_INFO_TAP2_MIN_DELAY:
>  			*val = st->tap_latent_us;
> -			*val2 = 1000000;
> +			*val2 = MICRO;
>  			return IIO_VAL_FRACTIONAL;
>  		default:
>  			return -EINVAL;