| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202506142133.g9g2Gp1d-lkp@intel.com>
Date: Sat, 14 Jun 2025 22:03:50 +0800
From: kernel test robot <lkp@...el.com>
To: Steve Siwinski <stevensiwinski@...il.com>,
mpi3mr-linuxdrv.pdl@...adcom.com
Cc: oe-kbuild-all@...ts.linux.dev, gustavoars@...nel.org,
James.Bottomley@...senpartnership.com, kashyap.desai@...adcom.com,
kees@...nel.org, linux-kernel@...r.kernel.org,
linux-scsi@...r.kernel.org, martin.petersen@...cle.com,
prayas.patel@...adcom.com, ranjan.kumar@...adcom.com,
sathya.prakash@...adcom.com, sreekanth.reddy@...adcom.com,
ssiwinski@...o.com, sumit.saxena@...adcom.com, bgrove@...o.com,
tdoedline@...o.com
Subject: Re: [PATCH 2/2] scsi: mpi3mr: Add initialization for ATTO 24Gb SAS
HBAs
Hi Steve,
kernel test robot noticed the following build warnings:
[auto build test WARNING on jejb-scsi/for-next]
[also build test WARNING on mkp-scsi/for-next linus/master v6.16-rc1 next-20250613]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Steve-Siwinski/scsi-mpi3mr-Add-initialization-for-ATTO-24Gb-SAS-HBAs/20250614-043438
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
patch link: https://lore.kernel.org/r/20250613202941.62114-2-ssiwinski%40atto.com
patch subject: [PATCH 2/2] scsi: mpi3mr: Add initialization for ATTO 24Gb SAS HBAs
config: microblaze-randconfig-r112-20250614 (https://download.01.org/0day-ci/archive/20250614/202506142133.g9g2Gp1d-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 12.4.0
reproduce: (https://download.01.org/0day-ci/archive/20250614/202506142133.g9g2Gp1d-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506142133.g9g2Gp1d-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> drivers/scsi/mpi3mr/mpi3mr_fw.c:4248:54: sparse: sparse: cast to restricted __le32
>> drivers/scsi/mpi3mr/mpi3mr_fw.c:4248:54: sparse: sparse: cast to restricted __le32
>> drivers/scsi/mpi3mr/mpi3mr_fw.c:4248:54: sparse: sparse: cast to restricted __le32
>> drivers/scsi/mpi3mr/mpi3mr_fw.c:4248:54: sparse: sparse: cast to restricted __le32
>> drivers/scsi/mpi3mr/mpi3mr_fw.c:4248:54: sparse: sparse: cast to restricted __le32
>> drivers/scsi/mpi3mr/mpi3mr_fw.c:4248:54: sparse: sparse: cast to restricted __le32
>> drivers/scsi/mpi3mr/mpi3mr_fw.c:4286:24: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned long long [usertype] q @@ got restricted __le64 [usertype] @@
drivers/scsi/mpi3mr/mpi3mr_fw.c:4286:24: sparse: expected unsigned long long [usertype] q
drivers/scsi/mpi3mr/mpi3mr_fw.c:4286:24: sparse: got restricted __le64 [usertype]
>> drivers/scsi/mpi3mr/mpi3mr_fw.c:4347:45: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le64 [usertype] device_name @@ got unsigned long long [addressable] [assigned] [usertype] q @@
drivers/scsi/mpi3mr/mpi3mr_fw.c:4347:45: sparse: expected restricted __le64 [usertype] device_name
drivers/scsi/mpi3mr/mpi3mr_fw.c:4347:45: sparse: got unsigned long long [addressable] [assigned] [usertype] q
>> drivers/scsi/mpi3mr/mpi3mr_fw.c:4348:42: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le64 [usertype] ioc_wwid @@ got unsigned long long [addressable] [assigned] [usertype] q @@
drivers/scsi/mpi3mr/mpi3mr_fw.c:4348:42: sparse: expected restricted __le64 [usertype] ioc_wwid
drivers/scsi/mpi3mr/mpi3mr_fw.c:4348:42: sparse: got unsigned long long [addressable] [assigned] [usertype] q
>> drivers/scsi/mpi3mr/mpi3mr_fw.c:4349:43: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le64 [usertype] sata_wwid @@ got unsigned long long [addressable] [assigned] [usertype] q @@
drivers/scsi/mpi3mr/mpi3mr_fw.c:4349:43: sparse: expected restricted __le64 [usertype] sata_wwid
drivers/scsi/mpi3mr/mpi3mr_fw.c:4349:43: sparse: got unsigned long long [addressable] [assigned] [usertype] q
drivers/scsi/mpi3mr/mpi3mr_fw.c:5256:24: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned char [addressable] [assigned] [usertype] class @@ got restricted __le16 [usertype] @@
drivers/scsi/mpi3mr/mpi3mr_fw.c:5256:24: sparse: expected unsigned char [addressable] [assigned] [usertype] class
drivers/scsi/mpi3mr/mpi3mr_fw.c:5256:24: sparse: got restricted __le16 [usertype]
>> drivers/scsi/mpi3mr/mpi3mr_fw.c:6720:23: sparse: sparse: restricted __le16 degrades to integer
vim +4248 drivers/scsi/mpi3mr/mpi3mr_fw.c
4205
4206 /**
4207 * mpi3mr_atto_validate_nvram - validate the ATTO nvram
4208 *
4209 * @mrioc: Adapter instance reference
4210 * @nvram: ptr to the ATTO nvram structure
4211 * Return: 0 for success, non-zero for failure.
4212 */
4213 static int mpi3mr_atto_validate_nvram(struct mpi3mr_ioc *mrioc, struct ATTO_SAS_NVRAM *nvram)
4214 {
4215 int r = -EINVAL;
4216 union ATTO_SAS_ADDRESS *sasaddr;
4217 u32 len;
4218 u8 *pb;
4219 u8 cksum;
4220
4221 /* validate nvram checksum */
4222 pb = (u8 *) nvram;
4223 cksum = ATTO_SASNVR_CKSUM_SEED;
4224 len = sizeof(struct ATTO_SAS_NVRAM);
4225
4226 while (len--)
4227 cksum = cksum + pb[len];
4228
4229 if (cksum) {
4230 ioc_err(mrioc, "Invalid ATTO NVRAM checksum\n");
4231 return r;
4232 }
4233
4234 sasaddr = (union ATTO_SAS_ADDRESS *) nvram->sasaddr;
4235
4236 if (nvram->signature[0] != 'E'
4237 || nvram->signature[1] != 'S'
4238 || nvram->signature[2] != 'A'
4239 || nvram->signature[3] != 'S')
4240 ioc_err(mrioc, "Invalid ATTO NVRAM signature\n");
4241 else if (nvram->version > ATTO_SASNVR_VERSION)
4242 ioc_info(mrioc, "Invalid ATTO NVRAM version");
4243 else if ((nvram->sasaddr[7] & (ATTO_SAS_ADDR_ALIGN - 1))
4244 || sasaddr->b[0] != 0x50
4245 || sasaddr->b[1] != 0x01
4246 || sasaddr->b[2] != 0x08
4247 || (sasaddr->b[3] & 0xF0) != 0x60
> 4248 || ((sasaddr->b[3] & 0x0F) | le32_to_cpu(sasaddr->d[1])) == 0) {
4249 ioc_err(mrioc, "Invalid ATTO SAS address\n");
4250 } else
4251 r = 0;
4252 return r;
4253 }
4254
4255 /**
4256 * mpi3mr_atto_get_sas_addr - get the ATTO SAS address from driver page 2
4257 *
4258 * @mrioc: Adapter instance reference
4259 * @*sas_address: return sas address
4260 * Return: 0 for success, non-zero for failure.
4261 */
4262 static int mpi3mr_atto_get_sas_addr(struct mpi3mr_ioc *mrioc, union ATTO_SAS_ADDRESS *sas_address)
4263 {
4264 struct mpi3_driver_page2 *driver_pg2 = NULL;
4265 struct ATTO_SAS_NVRAM *nvram;
4266 u16 sz;
4267 int r;
4268 __be64 addr;
4269
4270 sz = mpi3mr_cfg_get_page_size(mrioc, MPI3_CONFIG_PAGETYPE_DRIVER, 2);
4271 driver_pg2 = kzalloc(sz, GFP_KERNEL);
4272 if (!driver_pg2)
4273 goto out;
4274
4275 r = mpi3mr_cfg_get_driver_pg2(mrioc, driver_pg2, sz, MPI3_CONFIG_ACTION_READ_PERSISTENT);
4276 if (r)
4277 goto out;
4278
4279 nvram = (struct ATTO_SAS_NVRAM *) &driver_pg2->trigger;
4280
4281 r = mpi3mr_atto_validate_nvram(mrioc, nvram);
4282 if (r)
4283 goto out;
4284
4285 addr = *((__be64 *) nvram->sasaddr);
> 4286 sas_address->q = cpu_to_le64(be64_to_cpu(addr));
4287
4288 out:
4289 kfree(driver_pg2);
4290 return r;
4291 }
4292
4293 /**
4294 * mpi3mr_atto_init - Initialize the controller
4295 * @mrioc: Adapter instance reference
4296 *
4297 * This the ATTO controller initialization routine
4298 *
4299 * Return: 0 on success and non-zero on failure.
4300 */
4301 static int mpi3mr_atto_init(struct mpi3mr_ioc *mrioc)
4302 {
4303 int i, bias = 0;
4304 u16 sz;
4305 struct mpi3_sas_io_unit_page0 *sas_io_unit_pg0 = NULL;
4306 struct mpi3_man_page5 *man_pg5 = NULL;
4307 union ATTO_SAS_ADDRESS base_address;
4308 union ATTO_SAS_ADDRESS dev_address;
4309 union ATTO_SAS_ADDRESS sas_address;
4310
4311 sz = mpi3mr_cfg_get_page_size(mrioc, MPI3_CONFIG_PAGETYPE_SAS_IO_UNIT, 0);
4312 sas_io_unit_pg0 = kzalloc(sz, GFP_KERNEL);
4313 if (!sas_io_unit_pg0)
4314 goto out;
4315
4316 if (mpi3mr_cfg_get_sas_io_unit_pg0(mrioc, sas_io_unit_pg0, sz)) {
4317 ioc_err(mrioc, "failure at %s:%d/%s()!\n",
4318 __FILE__, __LINE__, __func__);
4319 goto out;
4320 }
4321
4322 sz = mpi3mr_cfg_get_page_size(mrioc, MPI3_CONFIG_PAGETYPE_MANUFACTURING, 5);
4323 man_pg5 = kzalloc(sz, GFP_KERNEL);
4324 if (!man_pg5)
4325 goto out;
4326
4327 if (mpi3mr_cfg_get_man_pg5(mrioc, man_pg5, sz)) {
4328 ioc_err(mrioc, "failure at %s:%d/%s()!\n",
4329 __FILE__, __LINE__, __func__);
4330 goto out;
4331 }
4332
4333 mpi3mr_atto_get_sas_addr(mrioc, &base_address);
4334
4335 dev_address.q = base_address.q;
4336 dev_address.b[0] += ATTO_SAS_ADDR_DEVNAME_BIAS;
4337
4338 for (i = 0; i < man_pg5->num_phys; i++) {
4339 if (sas_io_unit_pg0->phy_data[i].phy_flags &
4340 (MPI3_SASIOUNIT0_PHYFLAGS_HOST_PHY |
4341 MPI3_SASIOUNIT0_PHYFLAGS_VIRTUAL_PHY))
4342 continue;
4343
4344 sas_address.q = base_address.q;
4345 sas_address.b[0] += bias++;
4346
> 4347 man_pg5->phy[i].device_name = dev_address.q;
> 4348 man_pg5->phy[i].ioc_wwid = sas_address.q;
> 4349 man_pg5->phy[i].sata_wwid = sas_address.q;
4350 }
4351
4352 if (mpi3mr_cfg_set_man_pg5(mrioc, man_pg5, sz))
4353 ioc_info(mrioc, "ATTO set manufacuring page 5 failed\n");
4354
4355 out:
4356 kfree(sas_io_unit_pg0);
4357 kfree(man_pg5);
4358
4359 return 0;
4360 }
4361
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists