lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202506142111.KG4EupOI-lkp@intel.com>
Date: Sat, 14 Jun 2025 22:15:18 +0800
From: kernel test robot <lkp@...el.com>
To: Jun Miao <jun.miao@...el.com>, sbhatta@...vell.com, kuba@...nel.org,
	oneukum@...e.com
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	qiang.zhang@...ux.dev, jun.miao@...el.com
Subject: Re: [PATCH v2] net: usb: Convert tasklet API to new bottom half
 workqueue mechanism

Hi Jun,

kernel test robot noticed the following build errors:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on usb/usb-next usb/usb-linus net/main net-next/main linus/master v6.16-rc1 next-20250613]
[cannot apply to horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jun-Miao/net-usb-Convert-tasklet-API-to-new-bottom-half-workqueue-mechanism/20250614-191339
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link:    https://lore.kernel.org/r/20250614111414.2502195-1-jun.miao%40intel.com
patch subject: [PATCH v2] net: usb: Convert tasklet API to new bottom half workqueue mechanism
config: nios2-randconfig-001-20250614 (https://download.01.org/0day-ci/archive/20250614/202506142111.KG4EupOI-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250614/202506142111.KG4EupOI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506142111.KG4EupOI-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/net/usb/usbnet.c: In function 'usbnet_resume':
>> drivers/net/usb/usbnet.c:1974:47: error: 'struct usbnet' has no member named 'bh'
    1974 |                         tasklet_schedule (&dev->bh);
         |                                               ^~


vim +1974 drivers/net/usb/usbnet.c

^1da177e4c3f41 drivers/usb/net/usbnet.c Linus Torvalds   2005-04-16  1931  
38bde1d4699af4 drivers/usb/net/usbnet.c David Brownell   2005-08-31  1932  int usbnet_resume (struct usb_interface *intf)
^1da177e4c3f41 drivers/usb/net/usbnet.c Linus Torvalds   2005-04-16  1933  {
^1da177e4c3f41 drivers/usb/net/usbnet.c Linus Torvalds   2005-04-16  1934  	struct usbnet		*dev = usb_get_intfdata(intf);
69ee472f270637 drivers/net/usb/usbnet.c Oliver Neukum    2009-12-03  1935  	struct sk_buff          *skb;
69ee472f270637 drivers/net/usb/usbnet.c Oliver Neukum    2009-12-03  1936  	struct urb              *res;
69ee472f270637 drivers/net/usb/usbnet.c Oliver Neukum    2009-12-03  1937  	int                     retval;
^1da177e4c3f41 drivers/usb/net/usbnet.c Linus Torvalds   2005-04-16  1938  
69ee472f270637 drivers/net/usb/usbnet.c Oliver Neukum    2009-12-03  1939  	if (!--dev->suspend_count) {
6eecdc5f95a393 drivers/net/usb/usbnet.c Dan Williams     2013-05-06  1940  		/* resume interrupt URB if it was previously submitted */
6eecdc5f95a393 drivers/net/usb/usbnet.c Dan Williams     2013-05-06  1941  		__usbnet_status_start_force(dev, GFP_NOIO);
68972efa657040 drivers/net/usb/usbnet.c Paul Stewart     2011-04-28  1942  
69ee472f270637 drivers/net/usb/usbnet.c Oliver Neukum    2009-12-03  1943  		spin_lock_irq(&dev->txq.lock);
69ee472f270637 drivers/net/usb/usbnet.c Oliver Neukum    2009-12-03  1944  		while ((res = usb_get_from_anchor(&dev->deferred))) {
a11a6544c0bf6c drivers/net/usb/usbnet.c Oliver Neukum    2007-08-03  1945  
69ee472f270637 drivers/net/usb/usbnet.c Oliver Neukum    2009-12-03  1946  			skb = (struct sk_buff *)res->context;
69ee472f270637 drivers/net/usb/usbnet.c Oliver Neukum    2009-12-03  1947  			retval = usb_submit_urb(res, GFP_ATOMIC);
69ee472f270637 drivers/net/usb/usbnet.c Oliver Neukum    2009-12-03  1948  			if (retval < 0) {
69ee472f270637 drivers/net/usb/usbnet.c Oliver Neukum    2009-12-03  1949  				dev_kfree_skb_any(skb);
638c5115a79498 drivers/net/usb/usbnet.c Ming Lei         2013-08-08  1950  				kfree(res->sg);
69ee472f270637 drivers/net/usb/usbnet.c Oliver Neukum    2009-12-03  1951  				usb_free_urb(res);
69ee472f270637 drivers/net/usb/usbnet.c Oliver Neukum    2009-12-03  1952  				usb_autopm_put_interface_async(dev->intf);
69ee472f270637 drivers/net/usb/usbnet.c Oliver Neukum    2009-12-03  1953  			} else {
860e9538a9482b drivers/net/usb/usbnet.c Florian Westphal 2016-05-03  1954  				netif_trans_update(dev->net);
69ee472f270637 drivers/net/usb/usbnet.c Oliver Neukum    2009-12-03  1955  				__skb_queue_tail(&dev->txq, skb);
69ee472f270637 drivers/net/usb/usbnet.c Oliver Neukum    2009-12-03  1956  			}
69ee472f270637 drivers/net/usb/usbnet.c Oliver Neukum    2009-12-03  1957  		}
69ee472f270637 drivers/net/usb/usbnet.c Oliver Neukum    2009-12-03  1958  
69ee472f270637 drivers/net/usb/usbnet.c Oliver Neukum    2009-12-03  1959  		smp_mb();
69ee472f270637 drivers/net/usb/usbnet.c Oliver Neukum    2009-12-03  1960  		clear_bit(EVENT_DEV_ASLEEP, &dev->flags);
69ee472f270637 drivers/net/usb/usbnet.c Oliver Neukum    2009-12-03  1961  		spin_unlock_irq(&dev->txq.lock);
75bd0cbdc21d80 drivers/net/usb/usbnet.c Ming Lei         2011-04-28  1962  
75bd0cbdc21d80 drivers/net/usb/usbnet.c Ming Lei         2011-04-28  1963  		if (test_bit(EVENT_DEV_OPEN, &dev->flags)) {
14a0d635d18d0f drivers/net/usb/usbnet.c Oliver Neukum    2014-03-26  1964  			/* handle remote wakeup ASAP
14a0d635d18d0f drivers/net/usb/usbnet.c Oliver Neukum    2014-03-26  1965  			 * we cannot race against stop
14a0d635d18d0f drivers/net/usb/usbnet.c Oliver Neukum    2014-03-26  1966  			 */
14a0d635d18d0f drivers/net/usb/usbnet.c Oliver Neukum    2014-03-26  1967  			if (netif_device_present(dev->net) &&
65841fd5132c39 drivers/net/usb/usbnet.c Ming Lei         2012-06-19  1968  				!timer_pending(&dev->delay) &&
65841fd5132c39 drivers/net/usb/usbnet.c Ming Lei         2012-06-19  1969  				!test_bit(EVENT_RX_HALT, &dev->flags))
ab6f148de28261 drivers/net/usb/usbnet.c Oliver Neukum    2012-08-26  1970  					rx_alloc_submit(dev, GFP_NOIO);
65841fd5132c39 drivers/net/usb/usbnet.c Ming Lei         2012-06-19  1971  
69ee472f270637 drivers/net/usb/usbnet.c Oliver Neukum    2009-12-03  1972  			if (!(dev->txq.qlen >= TX_QLEN(dev)))
1aa9bc5b2f4cf8 drivers/net/usb/usbnet.c Alexey Orishko   2012-03-14  1973  				netif_tx_wake_all_queues(dev->net);
69ee472f270637 drivers/net/usb/usbnet.c Oliver Neukum    2009-12-03 @1974  			tasklet_schedule (&dev->bh);
69ee472f270637 drivers/net/usb/usbnet.c Oliver Neukum    2009-12-03  1975  		}
75bd0cbdc21d80 drivers/net/usb/usbnet.c Ming Lei         2011-04-28  1976  	}
5d9d01a30204c9 drivers/net/usb/usbnet.c Oliver Neukum    2012-10-11  1977  
5d9d01a30204c9 drivers/net/usb/usbnet.c Oliver Neukum    2012-10-11  1978  	if (test_and_clear_bit(EVENT_DEVICE_REPORT_IDLE, &dev->flags))
5d9d01a30204c9 drivers/net/usb/usbnet.c Oliver Neukum    2012-10-11  1979  		usb_autopm_get_interface_no_resume(intf);
5d9d01a30204c9 drivers/net/usb/usbnet.c Oliver Neukum    2012-10-11  1980  
^1da177e4c3f41 drivers/usb/net/usbnet.c Linus Torvalds   2005-04-16  1981  	return 0;
^1da177e4c3f41 drivers/usb/net/usbnet.c Linus Torvalds   2005-04-16  1982  }
38bde1d4699af4 drivers/usb/net/usbnet.c David Brownell   2005-08-31  1983  EXPORT_SYMBOL_GPL(usbnet_resume);
^1da177e4c3f41 drivers/usb/net/usbnet.c Linus Torvalds   2005-04-16  1984  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ