linux-kernel - Re: [PATCH net-next v2] net: ti: icssg-prueth: Read firmware-names from device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250614163416.GT414686@horms.kernel.org>
Date: Sat, 14 Jun 2025 17:34:16 +0100
From: Simon Horman <horms@...nel.org>
To: MD Danish Anwar <danishanwar@...com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Meghana Malladi <m-malladi@...com>,
	linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, srk@...com,
	Vignesh Raghavendra <vigneshr@...com>,
	Roger Quadros <rogerq@...nel.org>
Subject: Re: [PATCH net-next v2] net: ti: icssg-prueth: Read firmware-names
 from device tree

On Fri, Jun 13, 2025 at 12:15:47PM +0530, MD Danish Anwar wrote:
> Refactor the way firmware names are handled for the ICSSG PRUETH driver.
> Instead of using hardcoded firmware name arrays for different modes (EMAC,
> SWITCH, HSR), the driver now reads the firmware names from the device tree
> property "firmware-name". Only the EMAC firmware names are specified in the
> device tree property. The firmware names for all other supported modes are
> generated dynamically based on the EMAC firmware names by replacing
> substrings (e.g., "eth" with "sw" or "hsr") as appropriate.
> 
> Example: Below are the firmwares used currently for PRU0 core
> 
> EMAC: ti-pruss/am65x-sr2-pru0-prueth-fw.elf
> SW  : ti-pruss/am65x-sr2-pru0-prusw-fw.elf
> HSR : ti-pruss/am65x-sr2-pru0-pruhsr-fw.elf
> 
> All three firmware names are same except for the operating mode.
> 
> In general for PRU0 core, firmware name is,
> 
>         ti-pruss/am65x-sr2-pru0-pru<mode>-fw.elf
> 
> Since the EMAC firmware names are defined in DT, driver will read those
> directly and for other modes swap the mode name. i.e. eth -> sw or
> eth -> hsr.
> 
> This preserves backwards compatibility as ICSSG driver is supported only
> by AM65x and AM64x. Both of these have "firmware-name" property
> populated in their device tree.
> 
> Signed-off-by: MD Danish Anwar <danishanwar@...com>
> ---
> v1 - v2: Changed commit message to include an example as suggested by 
>          Jakub Kicinski <kuba@...nel.org>
> 
> v1: https://lore.kernel.org/all/20250610052501.3444441-1-danishanwar@ti.com/

I agree with Jakub's comment in his review of v1 that the backwards
compatibility aspects seem fine. And, overall, the patch looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>