linux-kernel - [PATCH v2 0/3] firewire: ohci: use regular workqueue to handle 1394 OHCI AT/AR context events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250615133253.433057-1-o-takashi@sakamocchi.jp>
Date: Sun, 15 Jun 2025 22:32:50 +0900
From: Takashi Sakamoto <o-takashi@...amocchi.jp>
To: linux1394-devel@...ts.sourceforge.net
Cc: linux-kernel@...r.kernel.org
Subject: [PATCH v2 0/3] firewire: ohci: use regular workqueue to handle 1394 OHCI AT/AR context events

Hi,

This is the revised version of v1 patchset[1].

Last year, in Linux kernel v6.12, the bottom-halves for isochronous
contexts of 1394 OHCI PCI driver were changed to use workqueue instead of
tasklet (softIRQ)[2]. I have received no reports of any issues related to the
change until today. Therefore, I believe it's time to move on to the next
step.

This patchset updates the driver to use a regular workqueue (not WQ_BH) to
handle 1394 OHCI AT/AR context events. Unlike isochronous contexts, the
asynchronous contexts are used by the implementation of the SCSI over
IEEE 1394 protocol (sbp2). The workqueue is allocated with WQ_MEM_RECLAIM
flag so that it can still participate in memory reclaim paths.

With this change, all remaining uses of tasklets in the subsystem are
completely removed.

[1] https://lore.kernel.org/lkml/20250614113449.388758-1-o-takashi@sakamocchi.jp/
[2] https://lore.kernel.org/lkml/20240904125155.461886-1-o-takashi@sakamocchi.jp/

Changes from v1 patchset:

* Fix "error: cannot jump from this goto statement to its label"
    * https://lore.kernel.org/lkml/20250614113449.388758-1-o-takashi@sakamocchi.jp/
* Fix indentations.

Takashi Sakamoto (3):
  firewire: core: allocate workqueue for AR/AT request/response contexts
  firewire: ohci: use workqueue to handle events of AR request/response
    contexts
  firewire: ohci: use workqueue to handle events of AT request/response
    contexts

 drivers/firewire/core-card.c        | 48 +++++++++++++++------
 drivers/firewire/core-transaction.c |  7 +--
 drivers/firewire/net.c              |  4 +-
 drivers/firewire/ohci.c             | 67 +++++++++++++++--------------
 include/linux/firewire.h            | 12 +++++-
 5 files changed, 85 insertions(+), 53 deletions(-)

-- 
2.48.1