linux-kernel - Re: [PATCH v3 4/4] rust: str: implement `Borrow` and `BorrowMut` for `CString`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72keko32qoc9OHnQsJx8ae50c2x=kij6r_gkwpdF-9n6jw@mail.gmail.com>
Date: Sun, 15 Jun 2025 15:57:28 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Alexandre Courbot <acourbot@...dia.com>
Cc: Danilo Krummrich <dakr@...nel.org>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, 
	Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/4] rust: str: implement `Borrow` and `BorrowMut` for `CString`

On Sun, Jun 15, 2025 at 3:48 PM Alexandre Courbot <acourbot@...dia.com> wrote:
>
> I thought I could get away with it since it is in a test, and clippy
> does not seem to complain about it, but...

Hmm... It should:

error: unsafe block missing a safety comment
    --> rust/doctests_kernel_generated.rs:7973:24
     |
7973 | let foo_borrowed = Foo(unsafe {
CStr::from_bytes_with_nul_unchecked_mut(&mut str_data) });
     |
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Do you have the doctests enabled? i.e. CONFIG_RUST_KERNEL_DOCTESTS=y

> ... as penance (and for symmetry with `from_bytes_with_nul`), let me
> implement that so we don't need a safety block at all. :)

:)

Cheers,
Miguel