linux-kernel - Re: [PATCH v11 0/6] rust: reduce `as` casts, enable related lints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ-ks9=eWA-CCJn32cVQZhBnz=dgjPTt6av0Uw2m+_nfRXYcbA@mail.gmail.com>
Date: Sun, 15 Jun 2025 16:41:17 -0400
From: Tamir Duberstein <tamird@...il.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Masahiro Yamada <masahiroy@...nel.org>, Nathan Chancellor <nathan@...nel.org>, 
	Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, 
	Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>, 
	Brendan Higgins <brendan.higgins@...ux.dev>, David Gow <davidgow@...gle.com>, 
	Rae Moar <rmoar@...gle.com>, Bjorn Helgaas <bhelgaas@...gle.com>, 
	Luis Chamberlain <mcgrof@...nel.org>, Russ Weight <russ.weight@...ux.dev>, Rob Herring <robh@...nel.org>, 
	Saravana Kannan <saravanak@...gle.com>, Abdiel Janulgue <abdiel.janulgue@...il.com>, 
	Daniel Almeida <daniel.almeida@...labora.com>, Robin Murphy <robin.murphy@....com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	FUJITA Tomonori <fujita.tomonori@...il.com>, Nicolas Schier <nicolas.schier@...ux.dev>, 
	Frederic Weisbecker <frederic@...nel.org>, Lyude Paul <lyude@...hat.com>, 
	Thomas Gleixner <tglx@...utronix.de>, Anna-Maria Behnsen <anna-maria@...utronix.de>, 
	Benno Lossin <lossin@...nel.org>, Krzysztof Wilczyński <kwilczynski@...nel.org>, 
	John Stultz <jstultz@...gle.com>, Stephen Boyd <sboyd@...nel.org>, 
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, "Liam R. Howlett" <Liam.Howlett@...cle.com>, 
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org, 
	rust-for-linux@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	kunit-dev@...glegroups.com, linux-pci@...r.kernel.org, 
	linux-block@...r.kernel.org, devicetree@...r.kernel.org, 
	dri-devel@...ts.freedesktop.org, netdev@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v11 0/6] rust: reduce `as` casts, enable related lints

On Fri, Jun 13, 2025 at 2:14 PM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
>
> On Wed, Jun 11, 2025 at 12:23 PM Tamir Duberstein <tamird@...il.com> wrote:
> >
> > This series depends on "rust: retain pointer mut-ness in
> > `container_of!`"[1].
>
> Not anymore! :)
>
> > Signed-off-by: Tamir Duberstein <tamird@...il.com>
>
> Thanks for rebasing, Tamir, I appreciate it.
>
> This has a bunch of hits in configfs, cpufreq and Nova [1]. I guess
> you built without those enabled.
>
> Could you please fix those? Since this affects other maintainers that
> we need to ask the Acked-by to, let's try to at least give them the
> final state.

Oops, I missed this email! I will send v12 shortly with these fixed.
Is there an easy way to enable all the relevant rust configs?

>
> Thanks!
>
> Cheers,
> Miguel
>
> [1]
>
> warning: reference as raw pointer
>    --> rust/kernel/configfs.rs:429:9
>
> warning: reference as raw pointer
>    --> rust/kernel/configfs.rs:467:9
>
> warning: reference as raw pointer
>    --> rust/kernel/configfs.rs:479:9
>
> warning: `as` casting between raw pointers without changing their constness
>    --> rust/kernel/configfs.rs:564:48
>
> warning: reference as raw pointer
>    --> rust/kernel/configfs.rs:721:39
>
> warning: reference as raw pointer
>    --> rust/kernel/configfs.rs:764:35
>
> warning: reference as raw pointer
>    --> rust/kernel/configfs.rs:783:35
>
> warning: reference as raw pointer
>    --> rust/kernel/configfs.rs:764:35
>
> warning: reference as raw pointer
>    --> rust/kernel/configfs.rs:783:35
>
> warning: using `as _` conversion
>    --> rust/kernel/cpufreq.rs:650:45
>
> warning: `as` casting between raw pointers without changing their constness
>    --> rust/kernel/cpufreq.rs:650:45
>
> warning: using `as _` conversion
>   --> drivers/gpu/nova-core/driver.rs:22:64
>
> warning: casts from `u8` to `u32` can be expressed infallibly using `From`
>    --> drivers/gpu/nova-core/regs/macros.rs:267:26
>
> warning: casts from `u8` to `u32` can be expressed infallibly using `From`
>    --> drivers/gpu/nova-core/regs/macros.rs:267:26
>
> warning: casts from `u8` to `u32` can be expressed infallibly using `From`
>    --> drivers/gpu/nova-core/regs/macros.rs:267:26
>
> warning: casts from `u8` to `u32` can be expressed infallibly using `From`
>    --> drivers/gpu/nova-core/regs/macros.rs:267:26
>
> warning: casts from `u8` to `u32` can be expressed infallibly using `From`
>    --> drivers/gpu/nova-core/regs/macros.rs:267:26
>
> warning: casts from `u8` to `u32` can be expressed infallibly using `From`
>   --> drivers/gpu/nova-core/regs.rs:35:65