linux-kernel - Re: [PATCH 03/13] x86/kbuild: Remove ancient 'arch/i386/' and 'arch/x86_64/' directory removal 'archclean' target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aE6tldAZUCnmXJcu@gmail.com>
Date: Sun, 15 Jun 2025 13:25:09 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Brian Gerst <brgerst@...il.com>
Cc: linux-kernel@...r.kernel.org, "H . Peter Anvin" <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Borislav Petkov <bp@...en8.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	Vitaly Kuznetsov <vkuznets@...hat.com>,
	Jürgen Groß <jgross@...e.com>,
	Ard Biesheuvel <ardb@...nel.org>, Arnd Bergmann <arnd@...db.de>,
	David Woodhouse <dwmw@...zon.co.uk>,
	Masahiro Yamada <yamada.masahiro@...ionext.com>,
	Michal Marek <michal.lkml@...kovi.net>
Subject: Re: [PATCH 03/13] x86/kbuild: Remove ancient 'arch/i386/' and
 'arch/x86_64/' directory removal 'archclean' target


* Brian Gerst <brgerst@...il.com> wrote:

> On Thu, May 15, 2025 at 9:28 AM Ingo Molnar <mingo@...nel.org> wrote:
> >
> > We have to go back 17 years into Git history, to kernels that won't
> > even build or boot with modern build environments, to come across
> > the obsolete arch/i386/ and arch/x86_64/ directories.
> >
> > Remove some of their last functional residuals in the 'archclean' target.
> >
> > Signed-off-by: Ingo Molnar <mingo@...nel.org>
> > Cc: Ard Biesheuvel <ardb@...nel.org>
> > Cc: Arnd Bergmann <arnd@...db.de>
> > Cc: David Woodhouse <dwmw@...zon.co.uk>
> > Cc: H. Peter Anvin <hpa@...or.com>
> > Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> > Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>
> > Cc: Michal Marek <michal.lkml@...kovi.net>
> > ---
> >  arch/x86/Makefile | 4 ----
> >  1 file changed, 4 deletions(-)
> >
> > diff --git a/arch/x86/Makefile b/arch/x86/Makefile
> > index 594723005d95..4e7ac5e4b537 100644
> > --- a/arch/x86/Makefile
> > +++ b/arch/x86/Makefile
> > @@ -348,10 +348,6 @@ $(orc_hash_h): $(srctree)/arch/x86/include/asm/orc_types.h $(orc_hash_sh) FORCE
> >  archprepare: $(orc_hash_h)
> >  endif
> >
> > -archclean:
> > -       $(Q)rm -rf $(objtree)/arch/i386
> > -       $(Q)rm -rf $(objtree)/arch/x86_64
> > -
> >  define archhelp
> >    echo  '* bzImage             - Compressed kernel image (arch/x86/boot/bzImage)'
> >    echo  '  install             - Install kernel using (your) ~/bin/$(INSTALLKERNEL) or'
> 
> This does not remove the code that actually creates these old symlinks:
> 
> $ ll arch/x86_64/boot/bzImage
> lrwxrwxrwx. 1 bgerst bgerst 22 Jun 13 13:06 arch/x86_64/boot/bzImage
> -> ../../x86/boot/bzImage

I've zapped this commit too.

Thanks,

	Ingo