linux-kernel - Re: [cocci] [v4 2/5] arm64: tlb: Convert the opencoded field modify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b7e7e8a-c070-46e4-8e77-25117ec57de4@web.de>
Date: Mon, 16 Jun 2025 15:52:30 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Luo Jie <quic_luoj@...cinc.com>, cocci@...ia.fr
Cc: LKML <linux-kernel@...r.kernel.org>,
 linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.linux.dev,
 Andrew Lunn <andrew@...n.ch>, Catalin Marinas <catalin.marinas@....com>,
 Joey Gouly <joey.gouly@....com>, Julia Lawall <Julia.Lawall@...ia.fr>,
 "Kiran Kumar C.S.K" <quic_kkumarcs@...cinc.com>,
 Lei Wei <quic_leiwei@...cinc.com>, Marc Zyngier <maz@...nel.org>,
 Nicolas Palix <nicolas.palix@...g.fr>, Oliver Upton
 <oliver.upton@...ux.dev>, Pavithra R <quic_pavir@...cinc.com>,
 Rasmus Villemoes <linux@...musvillemoes.dk>,
 Suruchi Agarwal <quic_suruchia@...cinc.com>,
 Suzuki Poulose <suzuki.poulose@....com>, Will Deacon <will@...nel.org>,
 Yury Norov <yury.norov@...il.com>, Zenghui Yu <yuzenghui@...wei.com>,
 quic_linchen@...cinc.com
Subject: Re: [cocci] [v4 2/5] arm64: tlb: Convert the opencoded field modify

>>> Replace below code with the wrapper FIELD_MODIFY(MASK, &reg, val)
>>> - reg &= ~MASK;
>>> - reg |= FIELD_PREP(MASK, val);
…
> I will review the generated message to improve the formatting as you
> suggested, the next time I use it.
Would indentation be more helpful for the mentioned code excerpt
(instead of trying to describe lines with bullet points)?

Regards,
Markus